Re: [patch] PCI: disable MSI on more ATI NorthBridges

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jeff@...>
Cc: Daniel Barkalow <barkalow@...>, Linas Vepstas <linas@...>, Shane Huang <chunhao.huang@...>, <davem@...>, <gregkh@...>, <htejun@...>, <brice.goglin@...>, <david.gaarenstroom@...>, <linux-kernel@...>, <linux-pci@...>, <shane.huang@...>, <linux-ide@...>, Brice Goglin <brice@...>
Date: Monday, October 22, 2007 - 7:40 pm

Jeff Garzik <jeff@garzik.org> writes:


It's PCI 2.3.


MSI has been introduced by PCI 2.2 (and thus PCI-X 1.0) so there may
be devices with MSI but without INTx-disable bit. I guess I have some
early PCI-X hardware with MSI but I don't know if they have INTx-disable
bit and I can't currently test that.
And it probably doesn't matter.


The wording is:
10: This bit disables the device from asserting INTx#. A value of 0
enables the assertion of its INTx# signal. A value of 1 disables the
assertion of its INTx# signal. This bit's state after RST# is 0. Refer
to Section 6.8.1.3 for control of MSI.

So strictly speaking it mandates disabling/enabling INTx but says
nothing about other things (e.g. MSI). Some common sense dictates
it shouldn't disable MSI, I guess.

The "MSI Enable" description doesn't leave any doubt:
0: MSI Enable: If 1, the function is permitted to use MSI to request
service and is prohibited from using its INTx# pin [...]


Right.
-- 
Krzysztof Halasa
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RE: [patch] PCI: disable MSI on more ATI NorthBridges, Shane Huang, (Fri Oct 19, 9:17 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Linas Vepstas, (Fri Oct 19, 3:57 pm)
RE: [patch] PCI: disable MSI on more ATI NorthBridges, Shane Huang, (Sat Oct 20, 10:50 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, David Gaarenstroom, (Sat Oct 20, 4:52 pm)
RE: [patch] PCI: disable MSI on more ATI NorthBridges, Shane Huang, (Tue Oct 23, 6:56 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, David Miller, (Tue Oct 23, 10:41 pm)
RE: [patch] PCI: disable MSI on more ATI NorthBridges, Shane Huang, (Sun Oct 21, 2:00 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Jeff Garzik, (Fri Oct 19, 4:21 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Daniel Barkalow, (Mon Oct 22, 4:26 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Jeff Garzik, (Mon Oct 22, 4:41 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Krzysztof Halasa, (Mon Oct 22, 7:40 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Jeff Garzik, (Tue Oct 23, 6:13 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, David Miller, (Mon Oct 22, 7:58 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Daniel Barkalow, (Mon Oct 22, 5:31 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Jeff Garzik, (Tue Oct 23, 6:15 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, David Miller, (Mon Oct 22, 8:13 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Jeff Garzik, (Tue Oct 23, 6:01 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, David Miller, (Tue Oct 23, 6:06 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, David Miller, (Tue Oct 23, 10:46 pm)
RE: [patch] PCI: disable MSI on more ATI NorthBridges, Shane Huang, (Tue Oct 23, 5:39 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Daniel Barkalow, (Tue Oct 23, 1:52 am)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Krzysztof Halasa, (Mon Oct 22, 7:48 pm)
Re: [patch] PCI: disable MSI on more ATI NorthBridges, Benjamin Herrenschmidt, (Sat Oct 20, 6:03 pm)