Home » Mailing list archives » linux-kernel » 2007 » October » 22

[PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Grant Likely <grant.likely@...>
To: Olaf Hering <olh@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>, Paul Mackerras <paulus@...>, <linuxppc-dev@...>
Subject: [PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834
Date: Monday, October 22, 2007 - 6:38 pm

From: Grant Likely <grant.likely@secretlab.ca>

Commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834 changes the size of
AT_VECTOR_SIZE from hard coded '44' to a calculation based on the value
of AT_VECTOR_SIZE_ARCH and AT_VECTOR_SIZE_BASE.  The change works for
arch/powerpc, but it breaks arch/ppc because the needed
AT_VECTOR_SIZE_ARCH is not present in include/asm-ppc/system.h and a
default value of 0 is used instead.  This results in AT_VECTOR_SIZE
being too small and it causes a kernel crash on loading init.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

I think this bug fix needs to go in ASAP.  I cannot boot my Virtex ppc405
platform without it.

Olaf, do I have the correct solution here?

Thanks,
g.

 include/asm-ppc/system.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/asm-ppc/system.h b/include/asm-ppc/system.h
index cc45780..51df94c 100644
--- a/include/asm-ppc/system.h
+++ b/include/asm-ppc/system.h
@@ -33,6 +33,7 @@
 
 #define set_mb(var, value)	do { var = value; mb(); } while (0)
 
+#define AT_VECTOR_SIZE_ARCH 6 /* entries in ARCH_DLINFO */
 #ifdef CONFIG_SMP
 #define smp_mb()	mb()
 #define smp_rmb()	rmb()

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a2..., Grant Likely, (Mon Oct 22, 6:38 pm)
Re: [PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb1..., Olaf Hering, (Tue Oct 23, 2:37 am)
Re: [PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb1..., Linus Torvalds, (Tue Oct 23, 11:52 am)