Home » Mailing list archives » linux-kernel » 2007 » October » 22

Re: [PATCH 09/10] Change table chaining layout

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Alan Cox <alan@...>
Cc: Geert Uytterhoeven <geert@...>, Jens Axboe <jens.axboe@...>, Linux Kernel Development <linux-kernel@...>, <mingo@...>, Linux/m68k <linux-m68k@...>
Subject: Re: [PATCH 09/10] Change table chaining layout
Date: Monday, October 22, 2007 - 5:47 pm

On Mon, 22 Oct 2007, Alan Cox wrote:


I think m68k stack layout still guarantees 4-byte-alignment, no?


You still do need one bit for the discontiguous case, so it's not like you 
can avoid the hacks anyway (unless you just blow up the structure 
entirely) and make it a separate member). So once you have that 
bit+pointer, using a separate NULL entry isn't exactly prettier. 

Especially as we actally want to see the difference between 
"end-of-allocation" and "not yet filled in", so you shouldn't use NULL 
anyway, you should probably use something like "all-ones".

			Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/10] SG updates, Jens Axboe, (Mon Oct 22, 2:10 pm)
[PATCH][SG] fix typo in ps3rom.c, Arnd Bergmann, (Tue Oct 23, 10:48 am)
[PATCH 08/10] [SG] Update arch/ to use sg helpers, Jens Axboe, (Mon Oct 22, 2:11 pm)
Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers, Benny Halevy, (Mon Oct 22, 5:10 pm)
Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers, Jens Axboe, (Tue Oct 23, 3:26 am)
[PATCH 07/10] [SG] Update swiotlb to use sg helpers, Jens Axboe, (Mon Oct 22, 2:11 pm)
[PATCH 06/10] [SG] Update net/ to use sg helpers, Jens Axboe, (Mon Oct 22, 2:11 pm)
Re: [PATCH 06/10] [SG] Update net/ to use sg helpers, Christian Borntraeger, (Tue Oct 23, 6:44 am)
Re: [PATCH 06/10] [SG] Update net/ to use sg helpers, Jens Axboe, (Tue Oct 23, 6:45 am)
[PATCH 05/10] [SG] Update fs/ to use sg helpers, Jens Axboe, (Mon Oct 22, 2:10 pm)
[PATCH 04/10] [SG] Update drivers to use sg helpers, Jens Axboe, (Mon Oct 22, 2:10 pm)
Re: [PATCH 04/10] [SG] Update drivers to use sg helpers, Heiko Carstens, (Tue Oct 23, 2:28 am)
Re: [PATCH 04/10] [SG] Update drivers to use sg helpers, Jens Axboe, (Tue Oct 23, 3:14 am)
Re: [PATCH 04/10] [SG] Update drivers to use sg helpers, Heiko Carstens, (Tue Oct 23, 3:16 am)
[PATCH 03/10] [SG] Update crypto/ to sg helpers, Jens Axboe, (Mon Oct 22, 2:10 pm)
[PATCH 02/10] [SG] Update block layer to use sg helpers, Jens Axboe, (Mon Oct 22, 2:10 pm)
Re: [PATCH 02/10] [SG] Update block layer to use sg helpers, John Stoffel, (Tue Oct 23, 10:32 am)
Re: [PATCH 02/10] [SG] Update block layer to use sg helpers, Heiko Carstens, (Tue Oct 23, 1:13 am)
Re: [PATCH 02/10] [SG] Update block layer to use sg helpers, Jens Axboe, (Tue Oct 23, 1:16 am)
[PATCH] net: fix xfrm build - missing scatterlist.h include, Heiko Carstens, (Tue Oct 23, 1:44 am)
Re: [PATCH] net: fix xfrm build - missing scatterlist.h incl..., Jens Axboe, (Tue Oct 23, 3:28 am)
[PATCH] fix ll_rw_blk.c build on s390, Heiko Carstens, (Tue Oct 23, 1:42 am)
[PATCH 01/10] [SG] Add helpers for manipulating SG entries, Jens Axboe, (Mon Oct 22, 2:10 pm)
[PATCH 10/10] Add CONFIG_DEBUG_SG sg validation, Jens Axboe, (Mon Oct 22, 2:11 pm)
[PATCH 09/10] Change table chaining layout, Jens Axboe, (Mon Oct 22, 2:11 pm)
Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 1:08 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 2:33 pm)
Re: [PATCH 09/10] Change table chaining layout, Andi Kleen, (Tue Oct 23, 3:56 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 4:20 pm)
Re: [PATCH 09/10] Change table chaining layout, Andi Kleen, (Tue Oct 23, 4:57 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 5:44 pm)
Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Mon Oct 22, 3:39 pm)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Mon Oct 22, 3:49 pm)
Re: [PATCH 09/10] Change table chaining layout, Alan Cox, (Mon Oct 22, 4:16 pm)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Mon Oct 22, 4:44 pm)
Re: [PATCH 09/10] Change table chaining layout, Alan Cox, (Mon Oct 22, 5:43 pm)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Mon Oct 22, 5:47 pm)
Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 5:29 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 5:41 am)
Re: [PATCH 09/10] Change table chaining layout, Ingo Molnar, (Tue Oct 23, 6:33 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 6:56 am)
Re: [PATCH 09/10] Change table chaining layout, Ingo Molnar, (Tue Oct 23, 7:27 am)
Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Tue Oct 23, 3:23 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 2:56 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 5:46 pm)
Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 5:50 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 5:55 am)
Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 6:23 am)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Tue Oct 23, 11:22 am)
Re: [PATCH 09/10] Change table chaining layout, Rusty Russell, (Thu Oct 25, 4:40 am)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Thu Oct 25, 11:40 am)
Re: [PATCH 09/10] Change table chaining layout, Paul Mackerras, (Fri Oct 26, 1:01 am)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Fri Oct 26, 10:52 am)
[RFC PATCH 1/2] sg_ring instead of scatterlist chaining, Rusty Russell, (Mon Nov 5, 2:11 am)
Re: [RFC PATCH 1/2] sg_ring instead of scatterlist chaining, Randy Dunlap, (Mon Nov 5, 12:40 pm)
[RFC PATCH 2/2] sg_ring instead of scatterlist chaining in v..., Rusty Russell, (Mon Nov 5, 2:15 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Fri Oct 26, 1:28 pm)
Re: [PATCH 09/10] Change table chaining layout, Benny Halevy, (Thu Oct 25, 12:03 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Thu Oct 25, 5:11 am)
Re: [PATCH 09/10] Change table chaining layout, Rusty Russell, (Thu Oct 25, 7:54 am)
Re: [PATCH 09/10] Change table chaining layout, Rusty Russell, (Thu Oct 25, 8:03 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 4:05 am)
Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Wed Oct 24, 5:03 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 5:12 am)
Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Wed Oct 24, 11:16 am)
Re: [PATCH 09/10] Change table chaining layout, Olivier Galibert, (Wed Oct 24, 9:35 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 9:38 am)
Re: [PATCH 09/10] Change table chaining layout, Olivier Galibert, (Wed Oct 24, 9:45 am)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 6:29 am)
Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Tue Oct 23, 3:18 am)
Re: [PATCH 09/10] Change table chaining layout, David Miller, (Mon Oct 22, 8:07 pm)
Re: [PATCH 09/10] Change table chaining layout, Jeff Garzik, (Mon Oct 22, 5:21 pm)
Re: [PATCH 09/10] Change table chaining layout, Matt Mackall, (Mon Oct 22, 5:47 pm)
Re: [PATCH 09/10] Change table chaining layout, Alan Cox, (Mon Oct 22, 6:52 pm)
Re: [PATCH 09/10] Change table chaining layout, Matt Mackall, (Mon Oct 22, 7:46 pm)
Re: [PATCH 09/10] Change table chaining layout, Jeff Garzik, (Mon Oct 22, 8:11 pm)
Re: [PATCH 09/10] Change table chaining layout, Benny Halevy, (Mon Oct 22, 5:16 pm)
Re: [PATCH 09/10] Change table chaining layout, Matt Mackall, (Mon Oct 22, 4:38 pm)
Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Mon Oct 22, 3:52 pm)
powerpc: Fix fallout from sg_page() changes, Olof Johansson, (Tue Oct 23, 12:09 am)
Re: powerpc: Fix fallout from sg_page() changes, Jens Axboe, (Tue Oct 23, 3:13 am)
IB/ehca: Fix sg_page() fallout, Olof Johansson, (Tue Oct 23, 12:31 am)
Re: IB/ehca: Fix sg_page() fallout, Jens Axboe, (Tue Oct 23, 1:05 am)
Re: IB/ehca: Fix sg_page() fallout, Olof Johansson, (Tue Oct 23, 1:54 am)
Re: IB/ehca: Fix sg_page() fallout, Jens Axboe, (Tue Oct 23, 3:12 am)