Home » Mailing list archives » linux-kernel » 2007 » October » 22

Re: [PATCH 1/2] irq_flags_t: intro and core annotations

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Matthew Wilcox <matthew@...>
Cc: Arnd Bergmann <arnd@...>, Andrew Morton <akpm@...>, Ralf Baechle <ralf@...>, Alexey Dobriyan <adobriyan@...>, Al Viro <viro@...>, <viro@...>, <linux-kernel@...>, <linux-arch@...>
Subject: Re: [PATCH 1/2] irq_flags_t: intro and core annotations
Date: Monday, October 22, 2007 - 3:56 pm

On Mon, 22 Oct 2007, Matthew Wilcox wrote:

There's another issue: the "irqsave/irqrestore" versions are much safer 
than the plain "irq" versions, in case the caller already has interrupts 
disabled. 

So anybody making the change not only would need to make the performance 
argument, he'd better not be a janitor that blindly does the change 
without thinking about all call-sites etc..

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] irq_flags_t: intro and core annotations, Alexey Dobriyan, (Sat Oct 20, 7:55 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Roman Zippel, (Sat Oct 27, 3:20 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Alexey Dobriyan, (Sat Oct 27, 4:14 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Roman Zippel, (Sat Oct 27, 5:22 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Peter Zijlstra, (Sat Oct 27, 5:07 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Jan Engelhardt, (Thu Oct 25, 11:40 am)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Alexey Dobriyan, (Sat Oct 27, 4:24 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Herbert Xu, (Sat Oct 27, 9:24 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Jan Engelhardt, (Sat Oct 27, 4:32 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Al Viro, (Sat Oct 20, 8:54 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Alexey Dobriyan, (Sun Oct 21, 5:30 am)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Ralf Baechle, (Mon Oct 22, 11:29 am)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Andrew Morton, (Mon Oct 22, 2:21 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Arnd Bergmann, (Mon Oct 22, 3:10 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Matthew Wilcox, (Mon Oct 22, 3:47 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Linus Torvalds, (Mon Oct 22, 3:56 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Jeff Garzik, (Mon Oct 22, 4:47 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Herbert Xu, (Mon Oct 22, 11:33 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Jeff Garzik, (Tue Oct 23, 10:11 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Arnd Bergmann, (Wed Oct 24, 4:55 am)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, David Miller, (Mon Oct 22, 8:21 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Andrew Morton, (Mon Oct 22, 4:02 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Arnd Bergmann, (Mon Oct 22, 5:34 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Thomas Gleixner, (Mon Oct 22, 5:46 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Arnd Bergmann, (Mon Oct 22, 9:06 pm)
USB HCD: avoid duplicate local_irq_disable(), Arnd Bergmann, (Mon Oct 22, 9:28 pm)
Re: [linux-usb-devel] USB HCD: avoid duplicate local_irq_dis..., Alan Stern, (Tue Oct 23, 12:01 am)
Re: [linux-usb-devel] USB HCD: avoid duplicate local_irq_dis..., Greg KH, (Thu Oct 25, 2:33 pm)
Re: [linux-usb-devel] USB HCD: avoid duplicate local_irq_dis..., Alan Stern, (Sat Oct 27, 3:14 pm)
Re: [PATCH 1/2] irq_flags_t: intro and core annotations, Geert Uytterhoeven, (Mon Oct 22, 2:50 pm)