Home » Mailing list archives » linux-kernel » 2007 » October » 22

Re: Interaction between Xen and XFS: stray RW mappings

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <andi@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: dean gaudet <dean@...>, Nick Piggin <nickpiggin@...>, Xen-devel <xen-devel@...>, <Morten@...>, David Chinner <dgc@...>, Linux Kernel Mailing List <linux-kernel@...>, Bøgeskov <xen-users@...>, <xfs@...>, <xfs-masters@...>, Mark Williamson <mark.williamson@...>
Subject: Re: Interaction between Xen and XFS: stray RW mappings
Date: Monday, October 22, 2007 - 9:47 am

Jeremy Fitzhardinge <jeremy@goop.org> writes:

Again it not just upsets Xen, keeping mappings to freed pages is wrong generally 
and violates the x86 (and likely others like PPC) architecture because it can 
cause illegal caching attribute aliases.

The patch that went into the tree was really not correct -- this
bogus optimization should have been unconditionally removed
or if you really wanted an ifdef made dependent on !CONFIG_XEN &&
!CONFIG_AGP (and likely && !CONFIG_DRM && !CONFIG_anything else that
uses uncached mappings in memory). 

You just worked around the obvious failure and leave the non obvious
rare corruptions in, which isn't a good strategy.

-Andi
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Fri Oct 12, 12:58 pm)
Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Sun Oct 14, 6:56 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 15, 5:36 am)
Re: Interaction between Xen and XFS: stray RW mappings, Nick Piggin, (Mon Oct 15, 10:56 am)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 15, 7:07 am)
Re: Interaction between Xen and XFS: stray RW mappings, Benjamin Herrenschmidt, (Sun Oct 21, 6:16 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 22, 5:49 am)
Re: Interaction between Xen and XFS: stray RW mappings, Nick Piggin, (Mon Oct 15, 7:28 am)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 15, 8:54 am)
Re: Interaction between Xen and XFS: stray RW mappings, Dave Airlie, (Sun Oct 21, 8:17 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Sun Oct 14, 7:12 pm)
Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Sun Oct 14, 7:33 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Nick Piggin, (Mon Oct 15, 12:15 am)
Re: Interaction between Xen and XFS: stray RW mappings, dean gaudet, (Sun Oct 21, 11:18 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Sun Oct 21, 11:34 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 22, 9:47 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Mon Oct 22, 2:40 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 22, 3:07 pm)
Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Mon Oct 22, 6:32 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Mon Oct 22, 7:35 pm)
Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Mon Oct 22, 8:36 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Andi Kleen, (Tue Oct 23, 5:28 am)
[patch] Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Tue Oct 23, 3:04 am)
Re: [patch] Re: Interaction between Xen and XFS: stray RW ma..., Andi Kleen, (Tue Oct 23, 5:30 am)
[PATCH] Allow lazy unmapping by taking extra page references..., David Chinner, (Wed Oct 24, 12:36 am)
Re: [PATCH] Allow lazy unmapping by taking extra page refere..., Jeremy Fitzhardinge, (Wed Oct 24, 1:08 am)
[PATCH] Allow lazy unmapping by taking extra page references..., David Chinner, (Wed Oct 24, 5:48 pm)
Re: [PATCH] Allow lazy unmapping by taking extra page refere..., Jeremy Fitzhardinge, (Wed Oct 24, 6:46 pm)
Re: [PATCH] Allow lazy unmapping by taking extra page refere..., David Chinner, (Wed Oct 24, 7:21 pm)
Re: [patch] Re: Interaction between Xen and XFS: stray RW ma..., David Chinner, (Tue Oct 23, 8:41 am)
Re: [patch] Re: Interaction between Xen and XFS: stray RW ma..., Jeremy Fitzhardinge, (Tue Oct 23, 10:33 am)
Re: Interaction between Xen and XFS: stray RW mappings, Zachary Amsden, (Mon Oct 22, 8:16 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Mon Oct 22, 3:11 pm)
Re: Interaction between Xen and XFS: stray RW mappings, dean gaudet, (Mon Oct 22, 12:28 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Mon Oct 22, 2:32 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Nick Piggin, (Mon Oct 22, 12:39 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Mon Oct 22, 2:37 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Sun Oct 14, 8:57 pm)
Re: Interaction between Xen and XFS: stray RW mappings, Nick Piggin, (Mon Oct 15, 3:26 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Sun Oct 14, 11:42 pm)
Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Mon Oct 15, 12:11 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Mon Oct 15, 12:18 am)
Re: Interaction between Xen and XFS: stray RW mappings, David Chinner, (Mon Oct 15, 12:25 am)
Re: [xfs-masters] Re: Interaction between Xen and XFS: stray..., Christoph Hellwig, (Mon Oct 15, 4:31 am)
Re: Interaction between Xen and XFS: stray RW mappings, Jeremy Fitzhardinge, (Fri Oct 12, 1:08 pm)