Home » Mailing list archives » linux-kernel » 2007 » October » 22

[PATCH 02/13] Don't touch fs_struct in usermodehelper

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Bharata B Rao <bharata@...>
To: Andrew Morton <akpm@...>
Cc: Jan Blunck <jblunck@...>, Andreas Gruenbacher <agruen@...>, Christoph Hellwig <hch@...>, <viro@...>, <linux-kernel@...>
Subject: [PATCH 02/13] Don't touch fs_struct in usermodehelper
Date: Monday, October 22, 2007 - 2:55 am

From: Jan Blunck <jblunck@suse.de>

This test seems to be unnecessary since we always have rootfs mounted before
calling a usermodehelper.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Acked-by: Christoph Hellwig <hch@lst.de>
---
 kernel/kmod.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -173,10 +173,7 @@ static int ____call_usermodehelper(void 
 	 */
 	set_user_nice(current, 0);
 
-	retval = -EPERM;
-	if (current->fs->root)
-		retval = kernel_execve(sub_info->path,
-				sub_info->argv, sub_info->envp);
+	retval = kernel_execve(sub_info->path, sub_info->argv, sub_info->envp);
 
 	/* Exec failed? */
 	sub_info->retval = retval;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/13] Use struct path in struct nameidata, Bharata B Rao, (Mon Oct 22, 2:53 am)
Re: [PATCH 00/13] Use struct path in struct nameidata, Christoph Hellwig, (Mon Oct 22, 9:57 am)
Re: [PATCH 00/13] Use struct path in struct nameidata, Bharata B Rao, (Mon Oct 22, 10:33 pm)
Re: [PATCH 00/13] Use struct path in struct nameidata, Jan Blunck, (Tue Oct 23, 4:43 am)
Re: [PATCH 00/13] Use struct path in struct nameidata, Bharata B Rao, (Tue Oct 23, 11:31 pm)
Re: [PATCH 00/13] Use struct path in struct nameidata, Andrew Morton, (Mon Oct 22, 6:56 pm)
Re: [PATCH 00/13] Use struct path in struct nameidata, Jan Blunck, (Tue Oct 23, 4:39 am)
[PATCH 13/13] Rename {__}d_path() to {__}print_path() and fi..., Bharata B Rao, (Mon Oct 22, 3:04 am)
Re: [PATCH 13/13] Rename {__}d_path() to {__}print_path() an..., Christoph Hellwig, (Mon Oct 22, 6:14 am)
Re: [PATCH 13/13] Rename {__}d_path() to {__}print_path() an..., Andrew Morton, (Mon Oct 22, 6:56 pm)
[PATCH 12/13] Use struct path argument in proc_get_link(), Bharata B Rao, (Mon Oct 22, 3:03 am)
[PATCH 11/13] Make __d_path() to take a struct path argument, Bharata B Rao, (Mon Oct 22, 3:02 am)
[PATCH 10/13] Make set_fs_{root,pwd} take a struct path, Bharata B Rao, (Mon Oct 22, 3:02 am)
[PATCH 09/13] Use struct path in fs_struct, Bharata B Rao, (Mon Oct 22, 3:01 am)
[PATCH 08/13] Introduce path_get(), Bharata B Rao, (Mon Oct 22, 3:00 am)
[PATCH 07/13] Use path_put() in a few places instead of {mnt..., Bharata B Rao, (Mon Oct 22, 2:59 am)
[PATCH 05/13] Embed a struct path into struct nameidata inst..., Bharata B Rao, (Mon Oct 22, 2:58 am)
[PATCH 06/13] Introduce path_put(), Bharata B Rao, (Mon Oct 22, 2:59 am)
[PATCH 04/13] Move struct path into its own header, Bharata B Rao, (Mon Oct 22, 2:57 am)
[PATCH 03/13] Remove path_release_on_umount(), Bharata B Rao, (Mon Oct 22, 2:56 am)
[PATCH 02/13] Don't touch fs_struct in usermodehelper, Bharata B Rao, (Mon Oct 22, 2:55 am)
[PATCH 01/13] Don't touch fs_struct in drivers, Bharata B Rao, (Mon Oct 22, 2:54 am)