Home » Mailing list archives » linux-kernel » 2007 » October » 22

[PATCH] unlock before bug returns

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin
Subject: [PATCH] unlock before bug returns
Date: Sunday, October 21, 2007 - 7:10 pm

I think the unlock should be before bugging?

--
    unlock before bug returns
    
    Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 5a4cc20..c910170 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -357,9 +357,8 @@ void gpmc_cs_free(int cs)
 	spin_lock(&gpmc_mem_lock);
 	if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) {
 		printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
-		BUG();
 		spin_unlock(&gpmc_mem_lock);
-		return;
+		BUG();
 	}
 	gpmc_cs_disable_mem(cs);
 	release_resource(&gpmc_cs_mem[cs]);
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] unlock before bug returns, Roel Kluin, (Sun Oct 21, 7:10 pm)
Re: [PATCH] unlock before bug returns, Roel Kluin, (Sun Oct 21, 7:58 pm)
Re: [PATCH] unlock before bug returns, Rik van Riel, (Sun Oct 21, 9:10 pm)
Re: [PATCH] unlock before bug returns, Roel Kluin, (Mon Oct 22, 5:09 am)
Re: [PATCH] unlock before bug returns, Pekka Enberg, (Mon Oct 22, 5:40 am)
Re: [PATCH] unlock before bug returns, Rene Herman, (Mon Oct 22, 5:49 am)
Re: [PATCH] unlock before bug returns, Roel Kluin, (Mon Oct 22, 12:17 pm)