Home » Mailing list archives » linux-kernel » 2007 » October » 21

[PATCH 8/9] Unionfs: fix unionfs_setattr to handle ATTR_KILL_S*ID

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Erez Zadok <ezk@...>
To: <akpm@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <viro@...>, <hch@...>, Josef 'Jeff' Sipek <jsipek@...>, Christoph Hellwig <hch@...>, Jeff Layton <jlayton@...>, Andrew Morton <akpm@...>, Erez Zadok <ezk@...>
Subject: [PATCH 8/9] Unionfs: fix unionfs_setattr to handle ATTR_KILL_S*ID
Date: Sunday, October 21, 2007 - 7:51 pm

From: Jeff Layton <jlayton@redhat.com>

Don't allow unionfs_setattr to trip the BUG() in notify_change. Clear
ATTR_MODE if the either ATTR_KILL_S*ID is set. This also allows the
lower filesystem to interpret these bits in its own way.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Cc: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/inode.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 4e59ace..6ca52f4 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -1048,6 +1048,13 @@ static int unionfs_setattr(struct dentry *dentry, struct iattr *ia)
 	bend = dbend(dentry);
 	inode = dentry->d_inode;
 
+	/*
+	 * mode change is for clearing setuid/setgid. Allow lower filesystem
+	 * to reinterpret it in its own way.
+	 */
+	if (ia->ia_valid & (ATTR_KILL_SUID | ATTR_KILL_SGID))
+		ia->ia_valid &= ~ATTR_MODE;
+
 	for (bindex = bstart; (bindex <= bend) || (bindex == bstart);
 	     bindex++) {
 		lower_dentry = unionfs_lower_dentry_idx(dentry, bindex);
-- 
1.5.2.2

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT PULL -mm] 0/9 Unionfs updates/cleanups/fixes, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 1/9] Unionfs: security convert lsm into a static inte..., Erez Zadok, (Sun Oct 21, 7:51 pm)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Christoph Hellwig, (Mon Oct 22, 4:22 am)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Erez Zadok, (Mon Oct 22, 8:48 pm)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Christoph Hellwig, (Tue Oct 23, 5:07 am)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Erez Zadok, (Sat Oct 27, 7:01 pm)
[PATCH 8/9] Unionfs: fix unionfs_setattr to handle ATTR_KILL..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 7/9] Unionfs: remove for_writepages nfs workaround, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 3/9] Unionfs: support lower filesystems without write..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 9/9] Unionfs: remove obsolete #define and comment, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 2/9] Unionfs: slab api remove useless ctor parameter ..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 5/9] Unionfs: don't bother validating dentry if it ha..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 6/9] Unionfs: convert a printk to pr_debug in release, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 4/9] Unionfs: don't printk trivial message upon norma..., Erez Zadok, (Sun Oct 21, 7:51 pm)