Home » Mailing list archives » linux-kernel » 2007 » October » 21

[PATCH 4/9] Unionfs: don't printk trivial message upon normal rename-copyup

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Erez Zadok <ezk@...>
To: <akpm@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <viro@...>, <hch@...>, Erez Zadok <ezk@...>
Subject: [PATCH 4/9] Unionfs: don't printk trivial message upon normal rename-copyup
Date: Sunday, October 21, 2007 - 7:51 pm

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/rename.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
index 91d41d4..1ab474f 100644
--- a/fs/unionfs/rename.c
+++ b/fs/unionfs/rename.c
@@ -40,10 +40,12 @@ static int __unionfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 				       new_dentry, new_dentry->d_name.name,
 				       bindex);
 		if (IS_ERR(lower_new_dentry)) {
-			printk(KERN_ERR "unionfs: error creating directory "
-			       "tree for rename, bindex = %d, err = %ld\n",
-			       bindex, PTR_ERR(lower_new_dentry));
 			err = PTR_ERR(lower_new_dentry);
+			if (err == -EROFS)
+				goto out;
+			printk(KERN_ERR "unionfs: error creating directory "
+			       "tree for rename, bindex=%d err=%d\n",
+			       bindex, err);
 			goto out;
 		}
 	}
-- 
1.5.2.2

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT PULL -mm] 0/9 Unionfs updates/cleanups/fixes, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 1/9] Unionfs: security convert lsm into a static inte..., Erez Zadok, (Sun Oct 21, 7:51 pm)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Christoph Hellwig, (Mon Oct 22, 4:22 am)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Erez Zadok, (Mon Oct 22, 8:48 pm)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Christoph Hellwig, (Tue Oct 23, 5:07 am)
Re: [PATCH 1/9] Unionfs: security convert lsm into a static ..., Erez Zadok, (Sat Oct 27, 7:01 pm)
[PATCH 8/9] Unionfs: fix unionfs_setattr to handle ATTR_KILL..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 7/9] Unionfs: remove for_writepages nfs workaround, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 3/9] Unionfs: support lower filesystems without write..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 9/9] Unionfs: remove obsolete #define and comment, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 2/9] Unionfs: slab api remove useless ctor parameter ..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 5/9] Unionfs: don't bother validating dentry if it ha..., Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 6/9] Unionfs: convert a printk to pr_debug in release, Erez Zadok, (Sun Oct 21, 7:51 pm)
[PATCH 4/9] Unionfs: don't printk trivial message upon norma..., Erez Zadok, (Sun Oct 21, 7:51 pm)