login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
21
Re: [PATCH] Fix sched_domain sysctl registration again
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Ingo Molnar
Subject:
Re: [PATCH] Fix sched_domain sysctl registration again
Date: Sunday, October 21, 2007 - 12:43 am
* Milton D. Miller II <miltonm@realtime.net> wrote:
quoted text
> commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset > sched_load_balance flag) was not tested SCHED_DEBUG enabled as > committed as it dereferences NULL when used and it reordered the > sysctl registration to cause it to never show any domains or their > tunables. > > Fixes: > > 1) restore arch_init_sched_domains ordering > we can't walk the domains before we build them > > presently we register cpus with empty directories (no domain > directories or files). > > 2) make unregister_sched_domain_sysctl do nothing when already unregistered > detach_destroy_domains is now called one set of cpus at a time > unregister_syctl dereferences NULL if called with a null. > > While the the function would always dereference null if called > twice, in the previous code it was always called once and then > was followed a register. So only the hidden bug of the > sysctl_root_table not being allocated followed by an attempt to > free it would have shown the error. > > 3) always call unregister and register in partition_sched_domains > The code is "smart" about unregistering only needed domains. > Since we aren't guaranteed any calls to unregister, always > unregister. Without calling register on the way out we > will not have a table or any sysctl tree. > > 4) warn if register is called without unregistering > The previous table memory is lost, leaving pointers to the > later freed memory in sysctl and leaking the memory of the > tables.
thanks, applied. Ingo -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] Fix sched_domain sysctl registration again
, Milton D. Miller II
, (Sat Oct 20, 12:41 pm)
Re: [PATCH] Fix sched_domain sysctl registration again
, Ingo Molnar
, (Sun Oct 21, 12:43 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
swhiteho
[PATCH 42/51] [GFS2] Move inode deletion out of blocking_cb
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Benjamin Herrenschmidt
[git pull] Please pull powerpc.git merge branch
Ingo Molnar
Re: [RFC/RFT PATCH] sched: automated per tty task groups
Vivek Goyal
Re: [PATCH v4] sched: automated per session task groups
git
:
Mike Miller
git message
Junio C Hamano
Re: [PATCH] Detached HEAD (experimental)
Stefan Richter
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Jeff King
Re: [PATCH] t7004: test that "git-tag -u" implies "-s"
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
linux-btrfs
:
David Nicol
PATCH: btrfs ioctl for waiting for kernel cleaner thread task completions kernel c...
Ravi Pinjala
Re: btrfs write behavior on idle system
Chris Mason
Re: btrfs and swap files on SSD's ?
Chris Samuel
btrfs and swap files on SSD's ?
Carlos R. Mafra
Re: 2.6.33-rc2+ bug in fs/btrfs/ordered-data.c:672
git-commits-head
:
Linux Kernel Mailing List
libata: disable ATAPI AN by default
Linux Kernel Mailing List
i915: Don't whine when pci_enable_msi() fails.
Linux Kernel Mailing List
Documentation/timers/hpet_example.c: only build on X86
Linux Kernel Mailing List
ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
Linux Kernel Mailing List
kbuild: move bounds.h to include/generated
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker
[PATCH 1/5] dccp: Initialisation framework for feature negotiation
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
David Miller
Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem
Jeff Garzik
Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
Colocation donated by:
Syndicate