login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
21
Re: [PATCH] Fix sched_domain sysctl registration again
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Ingo Molnar <mingo@...>
To: Milton D. Miller II <miltonm@...>
Cc: Paul Jackson <pj@...>, Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, <linux-kernel@...>
Subject:
Re: [PATCH] Fix sched_domain sysctl registration again
Date: Sunday, October 21, 2007 - 3:43 am
* Milton D. Miller II <miltonm@realtime.net> wrote:
quoted text
> commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset > sched_load_balance flag) was not tested SCHED_DEBUG enabled as > committed as it dereferences NULL when used and it reordered the > sysctl registration to cause it to never show any domains or their > tunables. > > Fixes: > > 1) restore arch_init_sched_domains ordering > we can't walk the domains before we build them > > presently we register cpus with empty directories (no domain > directories or files). > > 2) make unregister_sched_domain_sysctl do nothing when already unregistered > detach_destroy_domains is now called one set of cpus at a time > unregister_syctl dereferences NULL if called with a null. > > While the the function would always dereference null if called > twice, in the previous code it was always called once and then > was followed a register. So only the hidden bug of the > sysctl_root_table not being allocated followed by an attempt to > free it would have shown the error. > > 3) always call unregister and register in partition_sched_domains > The code is "smart" about unregistering only needed domains. > Since we aren't guaranteed any calls to unregister, always > unregister. Without calling register on the way out we > will not have a table or any sysctl tree. > > 4) warn if register is called without unregistering > The previous table memory is lost, leaving pointers to the > later freed memory in sysctl and leaking the memory of the > tables.
thanks, applied. Ingo -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] Fix sched_domain sysctl registration again
, Milton D. Miller II
, (Sat Oct 20, 3:41 pm)
Re: [PATCH] Fix sched_domain sysctl registration again
, Ingo Molnar
, (Sun Oct 21, 3:43 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH
[GIT PATCH] driver core patches against 2.6.24
holzheu
Re: [RFC/PATCH] Documentation of kernel messages
FUJITA Tomonori
Re: Integration of SCST in the mainstream Linux kernel
openbsd-misc
:
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 13/37] dccp: Deprecate Ack Ratio sysctl
Arjan van de Ven
Re: [GIT]: Networking
Evgeniy Polyakov
Re: [BUG] New Kernel Bugs
Colocation donated by:
Who's online
There are currently
3 users
and
809 guests
online.
Online users
iphoneboating
Flawless666
Manowar
Syndicate