Home » Mailing list archives » linux-kernel » 2007 » October » 21

Re: Oops: [RFC] LinuxPPS (pre)patch

Previous thread: request_firmware() and in-kernel modules by Timur Tabi on Friday, October 19, 2007 - 1:35 pm. (3 messages)

Next thread: [PATCH] eccbuf is statically defined and always evaluate to true by Samuel Tardieu on Friday, October 19, 2007 - 1:26 pm. (4 messages)
[view original message]
From: Rodolfo Giometti <giometti@...>
To: <linux-kernel@...>
Cc: Andrew Morton <akpm@...>, David Woodhouse <dwmw2@...>
Subject: [RFC] LinuxPPS (pre)patch
Date: Friday, October 19, 2007 - 1:41 pm

Hello,


here my last patch of LinuxPPS.


Main differences from old versions is that now (finally) each PPS

source is a dedicated char device!


This thanks to an agreement with NTP people who suggested to me how to

interpret RFC 2783 in such a way even a dedicated char device is now

RFC complain.


Please, take a look at the code and report all suggestions and/or

needed modifications for kernel inclusion so I can provide a final

patch.


Ciao,


Rodolfo


-- 


GNU/Linux Solutions                  e-mail:    giometti@enneenne.com

Linux Device Driver                             giometti@gnudd.com

Embedded Systems                     		giometti@linux.it

UNIX programming                     phone:     +39 349 2432127

-
[view original message]
From: Rodolfo Giometti <giometti@...>
To: <linux-kernel@...>
Cc: Andrew Morton <akpm@...>, David Woodhouse <dwmw2@...>
Subject: Oops: [RFC] LinuxPPS (pre)patch
Date: Friday, October 19, 2007 - 1:53 pm

Sorry... attached. :)


Ciao,


Rodolfo


-- 


GNU/Linux Solutions                  e-mail:    giometti@enneenne.com

Linux Device Driver                             giometti@gnudd.com

Embedded Systems                     		giometti@linux.it

UNIX programming                     phone:     +39 349 2432127
[view original message]
From: Greg KH <greg@...>
To: Rodolfo Giometti <giometti@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>, David Woodhouse <dwmw2@...>
Subject: Re: Oops: [RFC] LinuxPPS (pre)patch
Date: Sunday, October 21, 2007 - 12:06 am

Please use a 'struct class' instead of a 'struct class_device'.  We have

almost rid the kernel of all usages of 'struct class_device' and want to

remove that structure entirely soon.  I'm aiming for 2.6.25 and it's

looking good.


So please don't add new instances of it, you can do all the same things

with a 'struct device' and it should be a very trivial change.


thanks,


greg k-h

-
[view original message]
From: Rodolfo Giometti <giometti@...>
To: Greg KH <greg@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>, David Woodhouse <dwmw2@...>
Subject: Re: Oops: [RFC] LinuxPPS (pre)patch
Date: Monday, October 22, 2007 - 3:47 pm

Ok, fixed. I'll repost my patch ASAP.


Ciao,


Rodolfo


-- 


GNU/Linux Solutions                  e-mail:    giometti@enneenne.com

Linux Device Driver                             giometti@gnudd.com

Embedded Systems                     		giometti@linux.it

UNIX programming                     phone:     +39 349 2432127

-
Previous thread: request_firmware() and in-kernel modules by Timur Tabi on Friday, October 19, 2007 - 1:35 pm. (3 messages)

Next thread: [PATCH] eccbuf is statically defined and always evaluate to true by Samuel Tardieu on Friday, October 19, 2007 - 1:26 pm. (4 messages)