Home » Mailing list archives » linux-kernel » 2007 » October » 20

[PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oleg Nesterov <oleg@...>
To: Andrew Morton <akpm@...>, Jens Axboe <axboe@...>
Cc: Nick <gentuu@...>, Randy Dunlap <randy.dunlap@...>, <linux-kernel@...>
Subject: [PATCH 2/2] blk_sync_queue() should cancel request_queue-&gt;unplug_work
Date: Saturday, October 20, 2007 - 8:20 am

(untested, needs an explicit ack/nack from maintainer)

blk_sync_queue() cancels the timer, but forgets to cancel the work.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- K/block/ll_rw_blk.c~2_blk	2007-10-13 14:51:42.000000000 +0400
+++ K/block/ll_rw_blk.c	2007-10-20 16:10:08.000000000 +0400
@@ -1723,6 +1723,7 @@ EXPORT_SYMBOL(blk_stop_queue);
 void blk_sync_queue(struct request_queue *q)
 {
 	del_timer_sync(&q->unplug_timer);
+	kblockd_flush_work(&q->unplug_work);
 }
 EXPORT_SYMBOL(blk_sync_queue);
 

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 2/2] blk_sync_queue() should cancel request_queue->..., Oleg Nesterov, (Sat Oct 20, 8:20 am)
Re: [PATCH 2/2] blk_sync_queue() should cancel request_queue..., Jens Axboe, (Sun Oct 21, 3:16 pm)