Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Brownell
Date: Friday, October 19, 2007 - 10:52 pm

> > -	if [ -r System.map -a -x $(DEPMOD) -a "$(SUBARCH)" == "$(ARCH)" ]; then \

"man test" shows that only "=" works ... that's for string equality,
which is what's being tested there.  And "==" is undefined (error).

If "==" were to kick in that would be for an arithmetic expression;
but "[" is (modulo wierdness) "test" not "expr".



My $SHELL is /bin/bash:

$ bash --version
GNU bash, version 3.2.13(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2005 Free Software Foundation, Inc.
$



I don't know how you managed to get it to work wtih "==".
String equality should be "=" in all /bin/sh versions.
It's been that way since it was written in pseudo-Algol.

- Dave

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 2.6.23-git] toplevel Makefile/depmod bugfix, David Brownell, (Fri Oct 19, 9:42 pm)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, Sam Ravnborg, (Fri Oct 19, 10:36 pm)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, Roland Dreier, (Fri Oct 19, 10:44 pm)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, David Brownell, (Fri Oct 19, 10:52 pm)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, Sam Ravnborg, (Sat Oct 20, 6:06 am)