Home » Mailing list archives » linux-kernel » 2007 » October » 20

Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: Sam Ravnborg <sam@...>
Cc: David Brownell <david-b@...>, <linux-kernel@...>
Subject: Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix
Date: Saturday, October 20, 2007 - 1:44 am

> Accoding to man bash "==" is used to test for equality and "=" is used for assignmnet.
 > I assume the above is a dash syntax error (dash is default on ubuntu IIRC).

My bash man page says the following under "CONDITIONAL EXPRESSIONS":

       string1 == string2
              True if the strings are equal.  = may be used in place
              of == for strict POSIX compliance.

This is bash 3.1 as packaged by Debian.

So I think "=" is the correct thing to use for compatibility with dash
or other non-bash shells, since as far as I know, there are no
situations where a comparison with "=" will fail but "==" will succed.
(ie "=" is strictly more compatible).

 - R.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 2.6.23-git] toplevel Makefile/depmod bugfix, David Brownell, (Sat Oct 20, 12:42 am)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, Sam Ravnborg, (Sat Oct 20, 1:36 am)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, David Brownell, (Sat Oct 20, 1:52 am)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, Sam Ravnborg, (Sat Oct 20, 9:06 am)
Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix, Roland Dreier, (Sat Oct 20, 1:44 am)