Home » Mailing list archives » linux-kernel » 2007 » October » 2

[PATCH] sky2: jumbo frame regression fix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stephen Hemminger <shemminger@...>
To: <pomac@...>, Jeff Garzik <jgarzik@...>
Cc: <Linux-kernel@...>, <netdev@...>
Subject: [PATCH] sky2: jumbo frame regression fix
Date: Tuesday, October 2, 2007 - 9:02 pm

Remove unneeded check that caused problems with jumbo frame sizes.
The check was recently added and is wrong.
When using jumbo frames the sky2 driver does fragmentation, so
rx_data_size is less than mtu.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

--- a/drivers/net/sky2.c	2007-10-02 17:56:31.000000000 -0700
+++ b/drivers/net/sky2.c	2007-10-02 17:58:56.000000000 -0700
@@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru
 	sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending;
 	prefetch(sky2->rx_ring + sky2->rx_next);
 
-	if (length < ETH_ZLEN || length > sky2->rx_data_size)
-		goto len_error;
-
 	/* This chip has hardware problems that generates bogus status.
 	 * So do only marginal checking and expect higher level protocols
 	 * to handle crap frames.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[BUG] sky2 errors in 2.6.23-rc9-git1, Ian Kumlien, (Tue Oct 2, 8:42 pm)
[PATCH] sky2: jumbo frame regression fix, Stephen Hemminger, (Tue Oct 2, 9:02 pm)
Re: [PATCH] sky2: jumbo frame regression fix, Jeff Garzik, (Wed Oct 3, 1:39 pm)
Re: [PATCH] sky2: jumbo frame regression fix, Ian Kumlien, (Tue Oct 2, 9:34 pm)
Re: [PATCH] sky2: jumbo frame regression fix, Bill Davidsen, (Wed Oct 3, 2:04 pm)
Re: [PATCH] sky2: jumbo frame regression fix, Ian Kumlien, (Wed Oct 3, 2:28 pm)
Re: [PATCH] sky2: jumbo frame regression fix, Stephen Hemminger, (Wed Oct 3, 12:59 am)
[SKY2] Problems (2.6.24-rc3-git1), Ian Kumlien, (Tue Nov 27, 7:07 pm)
[SKY2] Problems (2.6.24-rc3-git1), Ian Kumlien, (Tue Nov 27, 6:40 pm)
Re: [SKY2] Problems (2.6.24-rc3-git1), Stephen Hemminger, (Tue Nov 27, 6:57 pm)
Re: [PATCH] sky2: jumbo frame regression fix, , (Wed Oct 3, 4:29 am)
Re: [PATCH] sky2: jumbo frame regression fix, Ian Kumlien, (Wed Oct 3, 3:37 am)
Re: [PATCH] sky2: jumbo frame regression fix, Jeff Garzik, (Tue Oct 2, 9:07 pm)
Re: [PATCH] sky2: jumbo frame regression fix, Stephen Hemminger, (Wed Oct 3, 12:53 am)
Re: [PATCH] sky2: jumbo frame regression fix, Jeff Garzik, (Wed Oct 3, 12:58 am)