Home » Mailing list archives » linux-kernel » 2007 » October » 2

Re: [PATCH] input: move gameports out of SERIO menu

Previous thread: [PATCH] Fix SH DMAC code to handle PVR2 cascade by Adrian McMenamin on Tuesday, October 2, 2007 - 2:09 pm. (5 messages)

Next thread: Re: [PATCH 5/5] writeback: introduce writeback_control.more_io to indicate more io by David Chinner on Tuesday, October 2, 2007 - 2:47 pm. (2 messages)
[view original message]
From: Randy Dunlap
Subject: [PATCH] input: move gameports out of SERIO menu
Date: Tuesday, October 2, 2007 - 2:12 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

Move the gameport support menu out of the SERIO menu and put it
between touchscreens and misc. devices in the main input layer menu.
Change it to use menuconfig instead of config.

Or was it meant to be listed under Hardware I/O ports?
It sure seems odd there to me.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/input/Kconfig          |    4 ++--
 drivers/input/gameport/Kconfig |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

--- linux-2.6.23-rc8-mm1.orig/drivers/input/Kconfig
+++ linux-2.6.23-rc8-mm1/drivers/input/Kconfig
@@ -171,6 +171,8 @@ source "drivers/input/tablet/Kconfig"
 
 source "drivers/input/touchscreen/Kconfig"
 
+source "drivers/input/gameport/Kconfig"
+
 source "drivers/input/misc/Kconfig"
 
 endif
@@ -179,8 +181,6 @@ menu "Hardware I/O ports"
 
 source "drivers/input/serio/Kconfig"
 
-source "drivers/input/gameport/Kconfig"
-
 endmenu
 
 endmenu
--- linux-2.6.23-rc8-mm1.orig/drivers/input/gameport/Kconfig
+++ linux-2.6.23-rc8-mm1/drivers/input/gameport/Kconfig
@@ -1,8 +1,8 @@
 #
 # Gameport configuration
 #
-config GAMEPORT
-	tristate "Gameport support"
+menuconfig GAMEPORT
+	bool "Gameport support"
 	---help---
 	  Gameport support is for the standard 15-pin PC gameport. If you
 	  have a joystick, gamepad, gameport card, a soundcard with a gameport
-


[ message continues ]
[view original message]
From: Dmitry Torokhov
Subject: Re: [PATCH] input: move gameports out of SERIO menu
Date: Tuesday, October 2, 2007 - 2:38 pm

Hi Randy,


Yes, they are meant to be under "Hardware I/O" ports. Like serio ports
they represent hardware ports to which devices (such as gamepads or
a joysticks can be connected to).

-- 
Dmitry
-


[ message continues ]
Previous thread: [PATCH] Fix SH DMAC code to handle PVR2 cascade by Adrian McMenamin on Tuesday, October 2, 2007 - 2:09 pm. (5 messages)

Next thread: Re: [PATCH 5/5] writeback: introduce writeback_control.more_io to indicate more io by David Chinner on Tuesday, October 2, 2007 - 2:47 pm. (2 messages)