Re: F_DUPFD_CLOEXEC implementation

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Denys Vlasenko <vda.linux@...>
Cc: Al Viro <viro@...>, Ulrich Drepper <drepper@...>, Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Tuesday, October 2, 2007 - 3:52 pm

On Tue, 2 Oct 2007, Denys Vlasenko wrote:


This is mildly ugly, if you ask me. Those are socket functions, and the 
flags parameter contain some pretty specific network meanings.




You'll need an ad-hoc copy function though, since your memcpy-based one is 
gonna explode even before memcpy returns ;) You'll have problems with 
ref-counting too. And that layer is not designed to cleanly support that 
operation.
Unfortunately the "clean" solution would involve changing a whole bunch of 
code, and I don't feel exactly sure it'd be worth it.



- Davide


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
F_DUPFD_CLOEXEC implementation, Ulrich Drepper, (Fri Sep 28, 1:34 pm)
Re: F_DUPFD_CLOEXEC implementation, Denys Vlasenko, (Sat Sep 29, 8:31 pm)
Re: F_DUPFD_CLOEXEC implementation, Miquel van Smoorenburg, (Sun Sep 30, 8:59 pm)
Re: F_DUPFD_CLOEXEC implementation, Davide Libenzi, (Sun Sep 30, 7:11 pm)
Re: F_DUPFD_CLOEXEC implementation, Denys Vlasenko, (Sun Sep 30, 7:58 pm)
Re: F_DUPFD_CLOEXEC implementation, Davide Libenzi, (Sun Sep 30, 11:15 pm)
Re: F_DUPFD_CLOEXEC implementation, Denys Vlasenko, (Mon Oct 1, 6:07 am)
Re: F_DUPFD_CLOEXEC implementation, Al Viro, (Mon Oct 1, 2:16 pm)
Re: F_DUPFD_CLOEXEC implementation, Michael Tokarev, (Mon Oct 1, 2:53 pm)
Re: F_DUPFD_CLOEXEC implementation, Denys Vlasenko, (Mon Oct 1, 2:49 pm)
Re: F_DUPFD_CLOEXEC implementation, Davide Libenzi, (Mon Oct 1, 3:04 pm)
Re: F_DUPFD_CLOEXEC implementation, Denys Vlasenko, (Tue Oct 2, 5:28 am)
Re: F_DUPFD_CLOEXEC implementation, Davide Libenzi, (Tue Oct 2, 3:52 pm)
Re: F_DUPFD_CLOEXEC implementation, Davide Libenzi, (Fri Sep 28, 2:19 pm)
Re: F_DUPFD_CLOEXEC implementation, Ulrich Drepper, (Fri Sep 28, 2:23 pm)