login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
2
Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jan Kara
Subject:
Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
Date: Tuesday, October 2, 2007 - 3:06 am
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
quoted text
> index 0079b2c..d8fb795 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c
...
quoted text
> + > + raw_inode = ext2_get_inode(inode->i_sb, ino, &bh); > if (IS_ERR(raw_inode)) > goto bad_inode;
Hmm, why don't you use the return value from raw_inode? It can be either -EIO or -EINVAL if 'ino' was invalid... Otherwise the patch looks fine. Honza -- Jan Kara <jack@suse.cz> SuSE CR Labs -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 00/30] Remove iget() and read_inode()
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 01/30] IGET: Introduce a function to register iget ...
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 02/30] IGET: Use iget_failed() in AFS
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 03/30] IGET: Use iget_failed() in GFS2
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 04/30] IGET: Mark iget() and read_inode() as being ...
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 05/30] IGET: Stop AFFS from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 06/30] IGET: Stop autofs from using iget() and read ...
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 07/30] IGET: Stop BEFS from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:09 am)
[PATCH 08/30] IGET: Stop BFS from using iget() and read_in ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 09/30] IGET: Stop CIFS from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 10/30] IGET: Stop EFS from using iget() and read_in ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 11/30] IGET: Stop EXT2 from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 12/30] IGET: Stop EXT3 from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 13/30] IGET: Stop EXT4 from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 14/30] IGET: Stop FAT from using iget() and read_in ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 15/30] IGET: Stop FreeVXFS from using iget() and re ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 16/30] IGET: Stop FUSE from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 17/30] IGET: Stop HFSPLUS from using iget() and rea ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 18/30] IGET: Stop ISOFS from using read_inode()
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 19/30] IGET: Stop JFFS2 from using iget() and read_ ...
, David Howells
, (Mon Oct 1, 6:10 am)
[PATCH 20/30] IGET: Stop JFS from using iget() and read_in ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 21/30] IGET: Stop the MINIX filesystem from using i ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 22/30] IGET: Stop PROCFS from using iget() and read ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 23/30] IGET: Stop QNX4 from using iget() and read_i ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 24/30] IGET: Stop ROMFS from using iget() and read_ ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 25/30] IGET: Stop the SYSV filesystem from using ig ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 26/30] IGET: Stop UFS from using iget() and read_in ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 27/30] IGET: Stop OPENPROMFS from using iget() and ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 28/30] IGET: Stop HOSTFS from using iget() and read ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 29/30] IGET: Stop HPPFS from using iget() and read_ ...
, David Howells
, (Mon Oct 1, 6:11 am)
[PATCH 30/30] IGET: Remove iget() and the read_inode() sup ...
, David Howells
, (Mon Oct 1, 6:11 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Zach Brown
, (Mon Oct 1, 10:39 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Linus Torvalds
, (Mon Oct 1, 10:44 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Christoph Hellwig
, (Mon Oct 1, 11:06 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Zach Brown
, (Mon Oct 1, 11:18 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Linus Torvalds
, (Mon Oct 1, 11:19 am)
Re: [PATCH 20/30] IGET: Stop JFS from using iget() and rea ...
, Dave Kleikamp
, (Mon Oct 1, 11:44 am)
Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and re ...
, Jan Kara
, (Tue Oct 2, 3:06 am)
Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and re ...
, Jan Kara
, (Tue Oct 2, 3:24 am)
Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and re ...
, Jan Kara
, (Tue Oct 2, 3:28 am)
Re: [PATCH 13/30] IGET: Stop EXT4 from using iget() and re ...
, Jan Kara
, (Tue Oct 2, 5:26 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, David Howells
, (Tue Oct 2, 5:32 am)
Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and re ...
, David Howells
, (Tue Oct 2, 5:58 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Dave Kleikamp
, (Tue Oct 2, 6:02 am)
Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and re ...
, David Howells
, (Tue Oct 2, 6:16 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, David Howells
, (Tue Oct 2, 6:24 am)
Re: [PATCH 13/30] IGET: Stop EXT4 from using iget() and re ...
, David Howells
, (Tue Oct 2, 6:37 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ...
, Dave Kleikamp
, (Tue Oct 2, 7:16 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: [PATCH 0/3] v2 Make hierarchical RCU less IPI-happy and add more tracing
Jeremy Fitzhardinge
Re: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Nick Piggin
Re: [patch] CFS (Completely Fair Scheduler), v2
Gary Hade
Re: [PATCH 0/5][RFC] Physical PCI slot objects
Dave Johnson
Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
linux-netdev
:
Arnd Bergmann
Re: 64-bit net_device_stats
Stephens, Allan
RE: [PATCH]: tipc: Fix oops on send prior to entering networked mode
frank.blaschka
[patch 3/5] [PATCH] qeth: support z/VM VSWITCH Port Isolation
Wu Fengguang
Re: [PATCH] dm9601: handle corrupt mac address
David Miller
Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()
git
:
Junio C Hamano
Re: [PATCH] [RFC] add Message-ID field to log on git-am operation
Junio C Hamano
Re: Handling large files with GIT
Karl
Re: [ANNOUNCE] pg - A patch porcelain for GIT
Josh Triplett
Re: [RFC][PATCH 00/10] Sparse: Git's "make check" target
Pierre Habouzit
Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.
git-commits-head
:
Linux Kernel Mailing List
MIPS: RBTX4939: Fix IOC pin-enable register updating
Linux Kernel Mailing List
regulator: update email address for Liam Girdwood
Linux Kernel Mailing List
[SCSI] ipr: add message to error table
Linux Kernel Mailing List
powerpc/32: Wire up the trampoline code for kdump
Linux Kernel Mailing List
USB: omap_udc: sync with OMAP tree
openbsd-misc
:
Josh Grosse
Re: error : pkg add phpMyAdmin
Brian Candler
Re: OBSD's perspective on SELinux
Jacob Meuser
Re: /dev/audio: Device busy
David Vasek
Re: Inexpensive, low power, "wall wart" computer
William Boshuck
Re: Richard Stallman...
Colocation donated by:
Syndicate