Re: [Git pull] arch/x86 updates

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Thomas Gleixner <tglx@...>
Cc: LKML <linux-kernel@...>, Ingo Molnar <mingo@...>
Date: Friday, October 19, 2007 - 6:04 pm

On Fri, 19 Oct 2007, Thomas Gleixner wrote:

While I think this is good otherwise, why does it do

	printk(".. comm: %.*s .."
		TASK_COMM_LEN, current->comm,

instead of just using "%s" and "current->comm"? I only noticed because 
there was an unrelated conflict around that thing.

That "current->comm" had better be NUL-terminated already, we use it as 
such all over the place. And if it's not, *that* should be fixed.

I'm editing it back to the simpler pure string.

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[Git pull] arch/x86 updates, Thomas Gleixner, (Fri Oct 19, 5:46 pm)
Re: [Git pull] arch/x86 updates, Linus Torvalds, (Fri Oct 19, 6:04 pm)
Re: [Git pull] arch/x86 updates, Ingo Molnar, (Fri Oct 19, 7:14 pm)
Re: [Git pull] arch/x86 updates, Thomas Gleixner, (Fri Oct 19, 6:19 pm)