Re: [PATCH] sparc/xen/cxgb3: use irq_handler_t where appropriate

Previous thread: [PATCH] Eliminate pointless casts from void* in a few driver irq handlers. by Jeff Garzik on Friday, October 19, 2007 - 3:31 am. (1 message)

Next thread: [PATCH] aha152x: delete pointless test in irq handler by Jeff Garzik on Friday, October 19, 2007 - 3:33 am. (1 message)
To: David Miller <davem@...>, <jeremy@...>, <netdev@...>
Cc: LKML <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Friday, October 19, 2007 - 3:33 am

commit 21b1f26bf54a2ba1e4072db6dd01da128b1f66ef
Author: Jeff Garzik <jeff@garzik.org>
Date: Fri Oct 19 03:12:20 2007 -0400

[SPARC, XEN, NET/CXGB3] use irq_handler_t where appropriate

Rather than hand-rolling our own prototype, make the code more
future-proof by using the standard irq_handler_t typedef.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

arch/sparc/kernel/irq.c | 4 ++--
arch/x86/xen/events.c | 4 ++--
drivers/net/cxgb3/adapter.h | 4 +---
drivers/net/cxgb3/sge.c | 2 +-
4 files changed, 6 insertions(+), 8 deletions(-)

21b1f26bf54a2ba1e4072db6dd01da128b1f66ef
diff --git a/arch/sparc/kernel/irq.c b/arch/sparc/kernel/irq.c
index 722d67d..e1e24f3 100644
--- a/arch/sparc/kernel/irq.c
+++ b/arch/sparc/kernel/irq.c
@@ -479,7 +479,7 @@ EXPORT_SYMBOL(pdma_areasize);

extern void floppy_hardint(void);

-static irqreturn_t (*floppy_irq_handler)(int irq, void *dev_id);
+static irq_handler_t floppy_irq_handler;

void sparc_floppy_irq(int irq, void *dev_id, struct pt_regs *regs)
{
@@ -500,7 +500,7 @@ void sparc_floppy_irq(int irq, void *dev_id, struct pt_regs *regs)
}

int sparc_floppy_request_irq(int irq, unsigned long flags,
- irqreturn_t (*irq_handler)(int irq, void *))
+ irq_handler_t irq_handler)
{
floppy_irq_handler = irq_handler;
return request_fast_irq(irq, floppy_hardint, flags, "floppy");
diff --git a/arch/x86/xen/events.c b/arch/x86/xen/events.c
index da1b173..6d1da58 100644
--- a/arch/x86/xen/events.c
+++ b/arch/x86/xen/events.c
@@ -383,7 +383,7 @@ static void unbind_from_irq(unsigned int irq)
}

int bind_evtchn_to_irqhandler(unsigned int evtchn,
- irqreturn_t (*handler)(int, void *),
+ irq_handler_t handler,
unsigned long irqflags,
const char *devname, void *dev_id)
{
@@ -402,7 +402,7 @@ int bind_evtchn_to_irqhandler(unsigned int evtchn,
EXPORT_SYMBOL_GPL(bind_evtchn_to_irqhandler);

int bind_virq_to_irqha...

To: Jeff Garzik <jeff@...>
Cc: David Miller <davem@...>, <jeremy@...>, <netdev@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Friday, October 19, 2007 - 3:54 am

-

Previous thread: [PATCH] Eliminate pointless casts from void* in a few driver irq handlers. by Jeff Garzik on Friday, October 19, 2007 - 3:31 am. (1 message)

Next thread: [PATCH] aha152x: delete pointless test in irq handler by Jeff Garzik on Friday, October 19, 2007 - 3:33 am. (1 message)