Home » Mailing list archives » linux-kernel » 2007 » October » 19

[PATCH] aha152x: delete pointless test in irq handler

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff Garzik <jeff@...>
To: <linux-scsi@...>
Cc: LKML <linux-kernel@...>, Andrew Morton <akpm@...>
Subject: [PATCH] aha152x: delete pointless test in irq handler
Date: Friday, October 19, 2007 - 3:33 am

commit c8f14a99beb85918935334a8374e47db12608d8e
Author: Jeff Garzik <jeff@garzik.org>
Date:   Fri Oct 19 03:17:14 2007 -0400

    [SCSI] aha152x: delete pointless test in irq handler
    
    Remove always-false test in interrupt handler.
    
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

 drivers/scsi/aha152x.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

c8f14a99beb85918935334a8374e47db12608d8e
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index f08e71e..973778a 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -1439,15 +1439,10 @@ static void run(struct work_struct *work)
  */
 static irqreturn_t intr(int irqno, void *dev_id)
 {
-	struct Scsi_Host *shpnt = (struct Scsi_Host *)dev_id;
+	struct Scsi_Host *shpnt = dev_id;
 	unsigned long flags;
 	unsigned char rev, dmacntrl0;
 
-	if (!shpnt) {
-		printk(KERN_ERR "aha152x: catched interrupt %d for unknown controller.\n", irqno);
-		return IRQ_NONE;
-	}
-
 	/*
 	 * Read a couple of registers that are known to not be all 1's. If
 	 * we read all 1's (-1), that means that either:
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] aha152x: delete pointless test in irq handler, Jeff Garzik, (Fri Oct 19, 3:33 am)