login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
19
Re: [NET]: Fix possible dev_deactivate race condition
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
David Miller <davem@...>
To: <herbert@...>
Cc: <benh@...>, <akpm@...>, <linux-kernel@...>, <linuxppc-dev@...>, <mingo@...>, <tglx@...>, <torvalds@...>, <netdev@...>
Subject:
Re: [NET]: Fix possible dev_deactivate race condition
Date: Friday, October 19, 2007 - 1:38 am
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Fri, 19 Oct 2007 13:36:24 +0800
quoted text
> [NET]: Fix possible dev_deactivate race condition > > The function dev_deactivate is supposed to only return when > all outstanding transmissions have completed. Unfortunately > it is possible for store operations in the driver's transmit > function to only become visible after dev_deactivate returns. > > This patch fixes this by taking the queue lock after we see > the end of the queue run. This ensures that all effects of > any previous transmit calls are visible. > > If however we detect that there is another queue run occuring, > then we'll warn about it because this should never happen as > we have pointed dev->qdisc to noop_qdisc within the same queue > lock earlier in the functino. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert! -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 9:25 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 10:02 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 11:56 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Sat Oct 20, 12:24 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sat Oct 20, 1:04 am)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Sat Oct 20, 1:36 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sat Oct 20, 1:46 am)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Sat Oct 20, 2:06 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sat Oct 20, 2:13 am)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Fri Oct 19, 11:37 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Fri Oct 19, 10:25 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sat Oct 20, 12:04 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sat Oct 20, 12:09 am)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 11:10 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sat Oct 20, 12:06 am)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Wed Oct 17, 10:12 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 10:40 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 10:35 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 5:35 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 10:57 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 10:56 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 6:05 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 6:52 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 7:17 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 7:39 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 10:32 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 10:55 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 11:26 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Fri Oct 19, 12:20 am)
[NET]: Fix possible dev_deactivate race condition
, Herbert Xu
, (Fri Oct 19, 1:36 am)
Re: [NET]: Fix possible dev_deactivate race condition
, Peter Zijlstra
, (Fri Oct 19, 3:35 am)
Re: [NET]: Fix possible dev_deactivate race condition
, Herbert Xu
, (Fri Oct 19, 5:29 am)
Re: [NET]: Fix possible dev_deactivate race condition
, David Miller
, (Fri Oct 19, 1:38 am)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Fri Oct 19, 12:48 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 12:58 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sun Oct 21, 5:10 pm)
[IRQ]: Fix synchronize_irq races with IRQ handler
, Herbert Xu
, (Mon Oct 22, 11:26 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 12:35 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 12:29 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 12:11 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 12:26 am)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Fri Oct 19, 1:53 am)
Re: [PATCH] synchronize_irq needs a barrier
, Nick Piggin
, (Thu Oct 18, 10:52 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 11:28 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Nick Piggin
, (Fri Oct 19, 12:49 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 7:52 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Andrew Morton
, (Wed Oct 17, 9:45 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 9:55 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Hiten Pandya
Re: up? (emacs docbook xml ide)
Martin Michlmayr
Network slowdown due to CFS
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
git
:
netbsd-tech-kern
:
Christos Zoulas
Re: Boot device confusion
Manuel Bouyer
Re: NFSv3 bug
Anders Magnusson
Re: setsockopt() compat issue
Martin Husemann
Re: Compressed vnd handling tested successfully
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
857 guests
online.
Syndicate