login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
18
Re: [PATCH] synchronize_irq needs a barrier
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Benjamin Herrenschmidt
Subject:
Re: [PATCH] synchronize_irq needs a barrier
Date: Thursday, October 18, 2007 - 2:35 pm
On Thu, 2007-10-18 at 22:35 +0800, Herbert Xu wrote:
quoted text
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > > > Note that some kind of read barrier or compiler barrier should be needed > > regardless, or we are just not sync'ing with anything at all (we may > > have loaded the value ages ago and thus operate on a totally stale > > value). I prefer a full barrier to also ensure all previous stores are > > pushed out. > > We already have a compiler barrier there in the form of cpu_relax.
Isn't it too late ? The barrier should be before the test_bit, to prevent it from moving up. Ben. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 6:25 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Andrew Morton
, (Wed Oct 17, 6:45 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 6:55 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Wed Oct 17, 7:12 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 7:40 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Wed Oct 17, 7:57 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 7:35 am)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 7:56 am)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 2:35 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 3:05 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 3:52 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 4:17 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 4:39 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 4:52 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 7:32 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Nick Piggin
, (Thu Oct 18, 7:52 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 7:55 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Thu Oct 18, 8:26 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 8:28 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 9:11 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 9:20 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 9:26 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 9:29 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 9:35 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 9:48 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Nick Piggin
, (Thu Oct 18, 9:49 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Thu Oct 18, 9:58 pm)
[NET]: Fix possible dev_deactivate race condition
, Herbert Xu
, (Thu Oct 18, 10:36 pm)
Re: [NET]: Fix possible dev_deactivate race condition
, David Miller
, (Thu Oct 18, 10:38 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Thu Oct 18, 10:53 pm)
Re: [NET]: Fix possible dev_deactivate race condition
, Peter Zijlstra
, (Fri Oct 19, 12:35 am)
Re: [NET]: Fix possible dev_deactivate race condition
, Herbert Xu
, (Fri Oct 19, 2:29 am)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 7:02 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Linus Torvalds
, (Fri Oct 19, 7:25 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 8:10 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Herbert Xu
, (Fri Oct 19, 8:37 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 8:56 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 9:04 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 9:06 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 9:09 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 9:24 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 10:04 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 10:36 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 10:46 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Maxim Levitsky
, (Fri Oct 19, 11:06 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Fri Oct 19, 11:13 pm)
Re: [PATCH] synchronize_irq needs a barrier
, Benjamin Herrenschmidt
, (Sun Oct 21, 2:10 pm)
[IRQ]: Fix synchronize_irq races with IRQ handler
, Herbert Xu
, (Mon Oct 22, 8:26 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Dave Jones
Re: OT: character encodings (was: Linux 2.6.20-rc4)
Greg Kroah-Hartman
[PATCH 17/36] sysdev: detect multiple driver registrations
Sam Ravnborg
Re: [PATCH] kbuild: fix make V=1
Nick Piggin
Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
Greg Kroah-Hartman
[PATCH 07/36] UIO: hold a reference to the device's owner while the device is open
git
:
Stephen R. van den Berg
Re: [RFC] origin link for cherry-pick and revert
Junio C Hamano
Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Junio C Hamano
Re: [PATCH 6/6] Teach core object handling functions about gitlinks
James Henstridge
Re: VCS comparison table
linux-netdev
:
Jarek Poplawski
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
Lennert Buytenhek
Re: Distributed Switch Architecture(DSA)
Daniel Schaffrath
Re: tcp bw in 2.6
Matt Mackall
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Guo-Fu Tseng
Re: jme: UDP checksum error, and lots of them
openbsd-misc
:
Claudio Jeker
Re: Vlan Tag on Vlan Tag (l2tunneling)
Josh Grosse
ssh/sshd challenge-response seems to have stopped working in -current
Pieter Verberne
File collision while using pkg_add
Tomas Bodzar
bsd: uvm_mapent_alloc: out of static map entries
Community First Financial
Teacher A+ Loan
git-commits-head
:
Linux Kernel Mailing List
ath9k: Added get_survey callback in order to get channel noise
Linux Kernel Mailing List
tracing: protect reader of cmdline output
Linux Kernel Mailing List
kconfig: recalc symbol value before showing search results
Linux Kernel Mailing List
KVM: VMX: Clear CR4.VMXE in hardware_disable
Linux Kernel Mailing List
swsusp: provide users with a hint about the no_console_suspend option
Colocation donated by:
Syndicate