Re: [PATCH 1/4] fix not-and/or errors

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roel Kluin
Date: Thursday, October 18, 2007 - 8:00 am

previously applied changes removed and changed as suggested.

    Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index 7dce318..752ae26 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, int mask)
 
 	switch (mask) {
 	case MLED_ON:
-		out = !out & 0x1;
+		out = !out;
 		break;
 	case GLED_ON:
 		out = (out & 0x1) + 1;
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 73c44cb..289165e 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -2882,7 +2882,8 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
 			    !(STp->use_pf & PF_TESTED)) {
 				/* Try the other possible state of Page Format if not
 				   already tried */
-				STp->use_pf = !STp->use_pf | PF_TESTED;
+				STp->use_pf ^= PF_TESTED | USE_PF; /* remove USE_PF, set *
+								    * PF_TESTED */
 				st_release_request(SRpnt);
 				SRpnt = NULL;
 				return st_int_ioctl(STp, cmd_in, arg);

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/4] fix not-and/or errors, Roel Kluin, (Wed Oct 17, 6:46 am)
[PATCH 2/4] fix not-and/or errors, Roel Kluin, (Wed Oct 17, 6:49 am)
Re: [PATCH 3/4] fix not-and/or errors, Roel Kluin, (Wed Oct 17, 6:53 am)
Re: [PATCH 2/4] fix not-and/or errors, Roel Kluin, (Wed Oct 17, 6:54 am)
[PATCH 4/4] fix not-and/or errors, Roel Kluin, (Wed Oct 17, 6:55 am)
Re: [PATCH 1/4] fix not-and/or errors, Peter Zijlstra, (Wed Oct 17, 7:02 am)
Re: [PATCH 2/4] fix not-and/or errors, Peter Zijlstra, (Wed Oct 17, 7:03 am)
Re: [PATCH 4/4] fix not-and/or errors, Peter Zijlstra, (Wed Oct 17, 7:05 am)
Re: [PATCH 1/4] fix not-and/or errors, Andreas Schwab, (Wed Oct 17, 7:17 am)
Re: [PATCH 1/4] fix not-and/or errors, Al Viro, (Wed Oct 17, 7:32 am)
Re: [PATCH 4/4] fix not-and/or errors, Al Viro, (Wed Oct 17, 7:35 am)
[PATCH 4/4 returns] fix not-and/or errors, Roel Kluin, (Thu Oct 18, 7:02 am)
Re: [PATCH 1/4] fix not-and/or errors, Roel Kluin, (Thu Oct 18, 7:38 am)
Re: [PATCH 1/4] fix not-and/or errors, Roel Kluin, (Thu Oct 18, 8:00 am)