Home » Mailing list archives » linux-kernel » 2007 » October » 18

[PATCH] move kvm_guest_exit() after local_irq_enable()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Laurent Vivier <Laurent.Vivier@...>
To: <mingo@...>
Cc: <linux-kernel@...>, <avi@...>, <borntraeger@...>, <kvm-devel@...>, Laurent Vivier <Laurent.Vivier@...>
Subject: [PATCH] move kvm_guest_exit() after local_irq_enable()
Date: Thursday, October 18, 2007 - 9:19 am

According comments from Avi, we can clear PF_VCPU in kvm_guest_exit if we move
it after local_irq_enable().

http://lkml.org/lkml/2007/10/15/114

To simplify s390 port, we don't clear it in account_system_time().

http://lkml.org/lkml/2007/10/15/183

---
 drivers/kvm/kvm_main.c |    5 ++++-
 kernel/sched.c         |    1 -
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index 87275be..b9cd1f0 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -2194,12 +2194,15 @@ again:
 
 	kvm_x86_ops->run(vcpu, kvm_run);
 
-	kvm_guest_exit();
 	vcpu->guest_mode = 0;
 	local_irq_enable();
 
 	++vcpu->stat.exits;
 
+	barrier();
+
+	kvm_guest_exit();
+
 	preempt_enable();
 
 	/*
diff --git a/kernel/sched.c b/kernel/sched.c
index b27ab3e..57fac22 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3315,7 +3315,6 @@ void account_system_time(struct task_struct *p, int hardirq_offset,
 #ifdef CONFIG_GUEST_ACCOUNTING
 	if (p->flags & PF_VCPU) {
 		account_guest_time(p, cputime);
-		p->flags &= ~PF_VCPU;
 		return;
 	}
 #endif
-- 
1.5.2.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RESEND 2][PATCH 4/4] Modify KVM to update guest time accoun..., Laurent Vivier, (Mon Sep 10, 10:13 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Ingo Molnar, (Mon Oct 15, 5:38 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Avi Kivity, (Mon Oct 15, 5:47 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Ingo Molnar, (Mon Oct 15, 5:51 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Avi Kivity, (Mon Oct 15, 6:02 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Laurent Vivier, (Mon Oct 15, 6:53 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest , Christian Borntraeger, (Mon Oct 15, 7:19 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Avi Kivity, (Mon Oct 15, 7:15 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Laurent Vivier, (Mon Oct 15, 7:37 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Avi Kivity, (Mon Oct 15, 8:07 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Laurent Vivier, (Mon Oct 15, 8:29 am)
[PATCH] move kvm_guest_exit() after local_irq_enable(), Laurent Vivier, (Thu Oct 18, 9:19 am)
Re: [PATCH] move kvm_guest_exit() after local_irq_enable(), Ingo Molnar, (Mon Oct 22, 4:26 am)
Re: [PATCH] move kvm_guest_exit() after local_irq_enable(), Avi Kivity, (Mon Oct 22, 4:51 am)
Re: [PATCH] move kvm_guest_exit() after local_irq_enable(), Ingo Molnar, (Mon Oct 22, 4:57 am)
Re: [kvm-devel] [PATCH] move kvm_guest_exit() after local_ir..., Avi Kivity, (Mon Oct 22, 5:10 am)
Re: [kvm-devel] [PATCH] move kvm_guest_exit() after local_ir..., Avi Kivity, (Thu Oct 18, 9:32 am)
Re: [kvm-devel] [PATCH] move kvm_guest_exit() after local_ir..., Laurent Vivier, (Thu Oct 18, 9:49 am)
[PATCH] clear PF_VCPU in kvm_guest_exit(), Laurent Vivier, (Wed Oct 17, 9:08 am)
Use virtual cpu accounting if available for guest times., Christian Borntraeger, (Thu Oct 18, 8:39 am)
Re: [kvm-devel] Use virtual cpu accounting if available for ..., Hollis Blanchard, (Fri Oct 19, 12:57 pm)
Re: [kvm-devel] Use virtual cpu accounting if available for ..., Hollis Blanchard, (Fri Oct 19, 1:18 pm)
Re: Use virtual cpu accounting if available for guest times., Avi Kivity, (Thu Oct 18, 8:41 am)
Re: [PATCH] clear PF_VCPU in kvm_guest_exit(), Avi Kivity, (Wed Oct 17, 10:16 am)
Re: [PATCH] clear PF_VCPU in kvm_guest_exit(), Laurent Vivier, (Wed Oct 17, 11:09 am)
Re: [PATCH] clear PF_VCPU in kvm_guest_exit(), Christian Borntraeger, (Wed Oct 17, 9:18 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Avi Kivity, (Mon Oct 15, 12:46 pm)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Laurent Vivier, (Mon Oct 15, 3:45 pm)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest , Christian Borntraeger, (Mon Oct 15, 7:33 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Laurent Vivier, (Mon Oct 15, 7:38 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Christian Borntraeger, (Mon Oct 15, 10:39 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Laurent Vivier, (Mon Oct 15, 10:45 am)
Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time ac..., Ingo Molnar, (Mon Oct 15, 5:50 am)