Re: [PATCH 1/3] iwl3945 & iwl4965: mark more functions/variables static

Previous thread: Re: [RFD] iptables: mangle table obsoletes filter table by Al Boldi on Friday, October 12, 2007 - 8:25 am. (5 messages)

Next thread: [PATCH 2/3] iwl3945 & iwl4965: keep headers separate by Christoph Hellwig on Friday, October 12, 2007 - 8:33 am. (1 message)
To: <yi.zhu@...>
Cc: <linux-wireless@...>, <linux-kernel@...>
Date: Friday, October 12, 2007 - 8:32 am

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/drivers/net/wireless/iwlwifi/iwl-3945.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/iwlwifi/iwl-3945.c 2007-10-12 10:57:09.000000000 +0200
+++ linux-2.6/drivers/net/wireless/iwlwifi/iwl-3945.c 2007-10-12 10:59:47.000000000 +0200
@@ -698,21 +698,6 @@ u8 iwl3945_sync_sta(struct iwl_priv *pri
return sta_id;
}

-void iwl_hw_card_show_info(struct iwl_priv *priv)
-{
- IWL_DEBUG_INFO("3945ABG HW Version %u.%u.%u\n",
- ((priv->eeprom.board_revision >> 8) & 0x0F),
- ((priv->eeprom.board_revision >> 8) >> 4),
- (priv->eeprom.board_revision & 0x00FF));
-
- IWL_DEBUG_INFO("3945ABG PBA Number %.*s\n",
- (int)sizeof(priv->eeprom.board_pba_number),
- priv->eeprom.board_pba_number);
-
- IWL_DEBUG_INFO("EEPROM_ANTENNA_SWITCH_TYPE is 0x%02X\n",
- priv->eeprom.antenna_switch_type);
-}
-
static int iwl3945_nic_set_pwr_src(struct iwl_priv *priv, int pwr_max)
{
int rc;
@@ -1761,7 +1746,7 @@ void iwl3945_reg_txpower_periodic(struct
&priv->thermal_periodic, REG_RECALIB_PERIOD * HZ);
}

-void iwl3945_bg_reg_txpower_periodic(struct work_struct *work)
+static void iwl3945_bg_reg_txpower_periodic(struct work_struct *work)
{
struct iwl_priv *priv = container_of(work, struct iwl_priv,
thermal_periodic.work);
Index: linux-2.6/drivers/net/wireless/iwlwifi/iwl-3945.h
===================================================================
--- linux-2.6.orig/drivers/net/wireless/iwlwifi/iwl-3945.h 2007-10-12 10:59:26.000000000 +0200
+++ linux-2.6/drivers/net/wireless/iwlwifi/iwl-3945.h 2007-10-12 10:59:29.000000000 +0200
@@ -34,7 +34,6 @@ extern int iwl_eeprom_aqcuire_semaphore(
extern __le32 iwl3945_get_antenna_flags(const struct iwl_priv *priv);
extern int iwl3945_init_hw_rate_table(struct iwl_priv *priv);
extern void iwl3945_reg_txpower_pe...

To: Christoph Hellwig <hch@...>
Cc: <linux-wireless@...>, <linux-kernel@...>
Date: Thursday, October 25, 2007 - 2:36 am

I think more of them could be static. Will send a updated patch later.

Thanks,
-yi
-

To: Christoph Hellwig <hch@...>
Cc: <yi.zhu@...>, <linux-wireless@...>, <linux-kernel@...>
Date: Thursday, October 18, 2007 - 4:26 am

ping.

---end quoted text---
-

To: Christoph Hellwig <hch@...>
Cc: Christoph Hellwig <hch@...>, <linux-wireless@...>, <linux-kernel@...>
Date: Thursday, October 18, 2007 - 4:38 am

Pong.

Sorry for the late response, I just come back from vacation. I'm looking
at your patches. Basically I agree with them. But I also have some other
patches pending. So I need to merge them together into one patch series
and send to the list ASAP.

Thanks,
-yi
-

Previous thread: Re: [RFD] iptables: mangle table obsoletes filter table by Al Boldi on Friday, October 12, 2007 - 8:25 am. (5 messages)

Next thread: [PATCH 2/3] iwl3945 & iwl4965: keep headers separate by Christoph Hellwig on Friday, October 12, 2007 - 8:33 am. (1 message)