linux-kernel mailing list

FromSubjectsort iconDate
Yasunori Goto
[Patch](memory hotplug) Make kmem_cache_node for SLUB on mem...
This patch fixes panic due to access NULL pointer of kmem_cache_node at discard_slab() after memory online. When memory online is called, kmem_cache_nodes are created for all SLUBs for new node whose memory are available. slab_mem_going_online_callback() is called to make kmem_cache_node() in callback of memory online event. If it (or other callbacks) fails, then slab_mem_offline_callback() is called for rollback. In memory offline, slab_mem_going_offline_callback() is called to shrink all s...
Oct 17, 11:25 pm 2007
Andrew Morton
Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on...
hm. There should be no linkage between memory hotpluggability and So that's slub. Does slab already have this functionality or are you not bothering to maintain slab in this area? -
Oct 17, 11:46 pm 2007
Yasunori Goto
[Patch 000/002](memory hotplug) Rearrange notifier of memory...
Hello. This patch set is to rearrange event notifier for memory hotplug, because the old notifier has some defects. For example, there is no information like new memory's pfn and # of pages for callback functions. Fortunately, nothing uses this notifier so far, there is no impact by this change. (SLUB will use this after this patch set to make kmem_cache_node structure). In addition, descriptions of notifer is added to memory hotplug document. This patch was a part of patch set to make kmem...
Oct 17, 11:20 pm 2007
Yasunori Goto
[Patch 001/002](memory hotplug) Make description of memory h...
Add description about event notification callback routine to the document. Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com> --- Documentation/memory-hotplug.txt | 58 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 55 insertions(+), 3 deletions(-) Index: current/Documentation/memory-hotplug.txt =================================================================== --- current.orig/Documentation/memory-hotplug.txt 2007-10-17 15:57:50.000000000 +0900 +++ current/Documentation...
Oct 17, 11:23 pm 2007
Yasunori Goto
[Patch 002/002](memory hotplug) rearrange patch for notifier...
Current memory notifier has some defects yet. (Fortunately, nothing uses it.) This patch is to fix and rearrange for them. - Add information of start_pfn, nr_pages, and node id if node status is changes from/to memoryless node for callback functions. Callbacks can't do anything without those information. - Add notification going-online status. It is necessary for creating per node structure before the node's pages are available. - Move GOING_OFFLINE status notification afte...
Oct 17, 11:23 pm 2007
Andrew Morton
Re: [Patch 002/002](memory hotplug) rearrange patch for noti...
perhaps that open-coded writeback_set_ratelimit() should become a notifier callback. -
Oct 17, 11:41 pm 2007
Mark Lord
[PATCH] Fix /proc/acpi/alarm BCD alarm encodings
Linus, this is your patch from a few weeks ago. It (still) solves problems for me here. This should go into 2.6.24. Fix BIN_TO_BCD()/BCD_TO_BIN() handling when setting the real-time alarm clock. Signed-off-by: Mark Lord <mlord@pobox.com> --- drivers/acpi/sleep/proc.c | 66 +++++++++++++++++++------------------------- 1 files changed, 29 insertions(+), 37 deletions(-) diff --git a/drivers/acpi/sleep/proc.c b/drivers/acpi/sleep/proc.c index 3839efd..1538355 100644 --- a/drivers/ac...
Oct 17, 11:18 pm 2007
Paul Menage
[PATCH] Simplify /proc/cgroups
This patch simplifies /proc/cgroups by removing pointers and some debugging information, and simply presenting a list of subsystems, which hierarchy they are part of (if any) and the number of cgroups created for that subsystem. Hierarchy id is determined by the bitmask of subsystem ids attached to that hierarchy. Signed-off-by: Paul Menage <menage@google.com> --- Several people have commented that /proc/cgroups is too confusing or contains strange information. Here's an attempt to simpl...
Oct 17, 10:56 pm 2007
KAMEZAWA Hiroyuki
Re: [PATCH] Simplify /proc/cgroups
On Wed, 17 Oct 2007 19:56:36 -0700 (PDT) Because subsys_bits is unsigned long, then %lu or %lx is better. Thanks, -Kame -
Oct 17, 11:17 pm 2007
Mark Lord
[PATCH 0/3] Fix two PEIe hotplug issues
Fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks (and others?) in conjunction with the modparam of pciehp_force=1. The PCIe Hotplug driver has two issues when used on Dell notebooks which lack ACPI BIOS support for PCIe hotplug: 1. The driver does not recognise cards that were inserted prior to the driver being modprobe'd. 2. The driver stops functioning after a suspend/resume (RAM) cycle, and needs to be rmmod'd and modprobe'd to get it working again. This p...
Oct 17, 10:57 pm 2007
Mark Lord
[PATCH 1/3] pciehp: hotplug: deal with pre-inserted ExpressC...
(repost to conform with akpm's subject line conventions) One of three patches to fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks (and others?) in conjunction with modparam of pciehp_force=1. Fix pciehp_probe() to deal with ExpressCard cards that were inserted prior to the driver being loaded. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- a/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 22:30:19.000000000 -0400 +++ b/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-...
Oct 17, 11:32 pm 2007
Mark Lord
[PATCH 2/3] pciehp: hotplug: split out hardware init from pc...
(repost to conform with akpm's subject line conventions) One of three patches to fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks (and others?) in conjunction with modparam of pciehp_force=1 Split out the hotplug hardware initialization code from pcie_init() into pcie_init_enable_events(), without changing any functionality. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- a/drivers/pci/hotplug/pciehp_hpc.c 2007-10-17 19:06:38.000000000 -0400 +++ b/drivers/pci...
Oct 17, 11:33 pm 2007
Mark Lord
[PATCH 3/3] pciehp: hotplug: reinit hotplug h/w on resume fr...
(repost to conform with akpm's subject line conventions) Make use of the previously split out pcie_init_enable_events() function to reinitialize the hotplug hardware on resume from suspend, but only when pciehp_force==1. Otherwise behaviour is unmodified. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- git12/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 19:28:23.000000000 -0400 +++ linux/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 19:31:22.000000000 -0400 @@ -37,7 +37,6 @@ #include "...
Oct 17, 11:34 pm 2007
Mark Lord
Re: [PATCH 0/3] Fix two PEIe hotplug issues
To make things simpler for distro people, I'm contemplating another patch in this series, to allow something like: pciehp_force=2 This would then *try* the ACPI BIOS calls, and only fall back to pcie_force=1 if the BIOS support fails. This would be an ideal default for most desktop/notebook distros to consider using. Without this, they don't have any good choice: use the defaults, and things fail on the most popular brand of machines in the marketplace. Use pciehp_force=1, and they may br...
Oct 17, 11:09 pm 2007
Mark Lord
Re: [PATCH 0/3] Fix two PEIe hotplug issues
Kristen, If you're happy with this set, please add your Acked-by (or whatever). Thanks, Mark -
Oct 17, 11:05 pm 2007
Mark Lord
[PATCH 2/3] pciehp_split_pcie_init
02_pciehp_split_pcie_init.patch: Split out the hotplug hardware initialization code from pcie_init() into pcie_init_enable_events(), without changing any functionality. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- git12/drivers/pci/hotplug/pciehp_hpc.c 2007-10-17 19:06:38.000000000 -0400 +++ linux/drivers/pci/hotplug/pciehp_hpc.c 2007-10-17 19:29:42.000000000 -0400 @@ -1067,99 +1067,22 @@ } #endif -int pcie_init(struct controller * ctrl, struct pcie_device *dev) +int pcie_ini...
Oct 17, 11:04 pm 2007
Mark Lord
[PATCH 1/3] pciehp_handle_preinserted_card
01_pciehp_handle_preinserted_card.patch: Fix pciehp_probe() to deal with ExpressCard cards that were inserted prior to the driver being loaded. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- git12/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 22:30:19.000000000 -0400 +++ linux/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 22:29:59.000000000 -0400 @@ -37,7 +37,6 @@ #include "pciehp.h" static void interrupt_event_handler(struct work_struct *work); -static int pciehp_enable_slot(stru...
Oct 17, 11:03 pm 2007
Mark Lord
[PATCH 3/3] pciehp_resume_reinit_hardware
03_pciehp_resume_reinit_hardware.patch: Make use of the previously split out pcie_init_enable_events() function to reinitialize the hotplug hardware on resume from suspend, but only when pciehp_force==1. Otherwise behaviour is unmodified. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- git12/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 19:28:23.000000000 -0400 +++ linux/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 19:31:22.000000000 -0400 @@ -37,7 +37,6 @@ #include "pciehp.h" st...
Oct 17, 11:02 pm 2007
Mark Lord
Re: [PATCH 2/3] pciehp_split_pcie_init
02_pciehp_split_pcie_init.patch: Split out the hotplug hardware initialization code from pcie_init() into pcie_init_enable_events(), without changing any functionality. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- git12/drivers/pci/hotplug/pciehp_hpc.c 2007-10-17 19:06:38.000000000 -0400 +++ linux/drivers/pci/hotplug/pciehp_hpc.c 2007-10-17 19:29:42.000000000 -0400 @@ -1067,99 +1067,22 @@ } #endif -int pcie_init(struct controller * ctrl, struct pcie_device *dev) +int pcie_ini...
Oct 17, 11:00 pm 2007
Mark Lord
Re: [PATCH 1/3] pciehp_handle_preinserted_card
01_pciehp_handle_preinserted_card.patch: Fix pciehp_probe() to deal with ExpressCard cards that were inserted prior to the driver being loaded. Signed-off-by: Mark Lord <mlord@pobox.com> --- --- git12/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 22:30:19.000000000 -0400 +++ linux/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 22:29:59.000000000 -0400 @@ -37,7 +37,6 @@ #include "pciehp.h" static void interrupt_event_handler(struct work_struct *work); -static int pciehp_enable_slot(stru...
Oct 17, 10:59 pm 2007
Linus Torvalds
Re: LSM conversion to static interface
Yeah, it did come up. Andrew, when he sent it on to me, said that the SuSE people were ok with it (AppArmor), but I'm with you - I applied it, but I'm also perfectly willing to unapply it if there actually are valid out-of-tree users that people push for not merging. So Í don't think this is settled in any way - please keep discussing, and bringing it up. I'm definitely not in the camp that thinks that LSM needs to be "controlled", but on the other hand, I'm also not going to undo that ...
Oct 17, 10:18 pm 2007
Thomas Fricaccia
LSM conversion to static interface
Like many of us who earn a good living with Linux (for over a decade now) and follow the kernel developer discussions with waxing and waning interest depending on topic, I noticed James Morris' proposal to eliminate the LSM in favor of ordaining SELinux as THE security framework forever and amen, followed by the definitive decision by Linus that LSM would remain. Well, good, I thought. Linux should continue to represent freedom for anyone to use basic technology in any way he sees fit. I turned my atte...
Oct 17, 9:34 pm 2007
Arjan van de Ven
Re: LSM conversion to static interface
On Wed, 17 Oct 2007 18:34:16 -0700 I think your statement isn't quite correct: it's not closed to out of tree security frameworks; it's no longer possible to do MODULES. You can easily patch any of the ones you mention in (and in fact, this is how distros that use apparmor will use it anyway). You are totally free to compile whatever security module you want into your kernel and use it... I would actually highly encourage that; the freedom to do that is what Linux is about. The problem with "loa...
Oct 17, 11:06 pm 2007
Casey Schaufler
Re: LSM conversion to static interface
I make no claims to worthyness, strongly deny being serious, Nope. I remain carefully neutral regarding the static/dynamic LSM issue. I was involved with the LSM when SELinux was still known as the Flask port and my development group proposed the first implementation, featuring authoritative hooks. Believe me, this The thing that killed authoritative hooks and that could kill LSM is the notion (which I refuse to take a side on) that out of tree I think the primary parties have gotten to the...
Oct 17, 10:03 pm 2007
Linus Torvalds
Re: LSM conversion to static interface
Indeed. I think there is certainly likely to be some small overlap, but I *think* they are largely independent issues - "do we want choice in securitu models" (a very emphatic YES as far as I'm concerned) vs "do we necessarily want to do them as out-of-tree modules" (I'd like people who actually *do* things like that to educate us on why and what they are doing). Hmm? Linus -
Oct 17, 10:21 pm 2007
Robert Hancock
Re: Inquiry data and emulated SG devices
(cc-ing linux-ide) This doesn't seem a very reliable way to identify an IDE device, as all that 0 means is that the device does not claim conformance to any standard. I would think it would be legitimate for an IDE device to put a value like 5 in there as well, if it complies with SPC-4.. In the case of libata though, that appears to be due to this code in drivers/ata/libata-scsi.c: /* ATAPI devices typically report zero for their SCSI version, * and sometimes deviate from the spec WRT re...
Oct 17, 9:22 pm 2007
Jeff Garzik
Re: Inquiry data and emulated SG devices
Via the this-doesnt-really-matter-but-it-should-be-noted department: According to the latest on t10.org, MMC retroactively permitted SCSI The above tweak is entirely software->software communication... as the comment you quoted notes, it's just a signal to the SCSI midlayer. At the moment, the SCSI midlayer assumes any device that reports scsi version as less than 2 is forced to SCSI version 2. Ultimately that's incorrect behavior for all ATAPI devices (and later MMC revisions). At...
Oct 17, 9:31 pm 2007
Benjamin Herrenschmidt
[PATCH] synchronize_irq needs a barrier
synchronize_irq needs at the very least a compiler barrier and a read barrier on SMP, but there are enough cases around where a write barrier is also needed and it's not a hot path so I prefer using a full smp_mb() here. It will degrade to a compiler barrier on !SMP. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- Index: linux-work/kernel/irq/manage.c =================================================================== --- linux-work.orig/kernel/irq/manage.c 2007-10-...
Oct 17, 9:25 pm 2007
Linus Torvalds
Re: [PATCH] synchronize_irq needs a barrier
So, what exactly does it protect against? At a minimum, this needs a comment in the changelog, and probably preferably in the source code too. The thing is, synchronize_irq() can only protect against interrupts that are *already*running* on another CPU, and the caller must have made sure that no new interrupts are coming in (or at least that whatever new interrupts that come in will not pick up a certain piece of data). So I can imagine that the smb_mb() is there so that the caller - wh...
Oct 17, 10:12 pm 2007
Benjamin Herrenschmidt
Re: [PATCH] synchronize_irq needs a barrier
One could argue that it's the caller that should do the mb() but that would really be asking for trouble. Since most usage scenario require it, and it's not a hot path, I prefer having it here. Note that some kind of read barrier or compiler barrier should be needed regardless, or we are just not sync'ing with anything at all (we may have loaded the value ages ago and thus operate on a totally stale value). I prefer a full barrier to also ensure all previous stores are That isn't always t...
Oct 17, 10:40 pm 2007
Benjamin Herrenschmidt
Re: [PATCH] synchronize_irq needs a barrier
Take a real life example: drivers/message/fusion/mptbase.c /* Disable interrupts! */ CHIPREG_WRITE32(&ioc->chip->IntMask, 0xFFFFFFFF); ioc->active = 0; synchronize_irq(pdev->irq); And we aren't in a spinlock here. That's just a random example grepped.... I think I see a few more. Then, some drivers like tg3 actually do an smp_mb() before calling synchronize_irq(). But then, some don't. I think trying to have all drivers be correct here is asking for trouble, we'...
Oct 17, 10:57 pm 2007
Andrew Morton
Re: [PATCH] synchronize_irq needs a barrier
On Thu, 18 Oct 2007 11:25:42 +1000 Anyone reading this code is going to ask "wtf is that for". It needs a comment telling them. mb() is the new lock_kernel(). Sigh. -
Oct 17, 9:45 pm 2007
Benjamin Herrenschmidt
Re: [PATCH] synchronize_irq needs a barrier
Ugh ? That sounds fairly obvious to me :-) we are reading a value, that is totally unordered, nothing to do about lock kernel or whatever, if we want the above statement to make any sense in any kind of usage scenario, it needs to be ordered vs. what happens before. For example, take a construct like: device->my_hw_is_off = 1; synchronize_irq(); turn_off_hardware(); That basically makes sure the irq either sees device->my_hw_is_off being set to 1, or if an irq handler is already...
Oct 17, 9:55 pm 2007
Jeff Garzik
[git patches] libata fixes
Well, the new driver is not a fix. Anyway -- still plugging away at debugging libata. It seems some outside changes are causing a bunch of my test boxes to crap themselves. These need to go up in the meantime, however. Maybe its the sg-chaining stuff, we'll see. I'm watching that thread closely (after recovering from an email outage). Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following ...
Oct 17, 9:08 pm 2007
Jeff Garzik
[git patches] net driver fixes
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/3c59x.c | 2 +- drivers/net/forcedeth.c | 27 ++++++++++------- drivers/net/fs_enet/fs_enet-main.c | 28 ++++++++++------- drivers/net/fs_enet/fs_enet.h | 1 + drivers/net/gianfar.c | 4 ++- drivers/net/gianfar.h | 1 - drivers/net/ibm_newemac/mal.c ...
Oct 17, 9:07 pm 2007
Shannon Nelson
[PATCH] I/OAT: Add completion callback for async_tx interfac...
The async_tx interface includes a completion callback. This adds support for using that callback, including using interrupts on completion. This second try does better at defining the callback prototype. Cc: David Miller <davem@davemloft.net> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> --- drivers/dma/ioat_dma.c | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c index 1...
Oct 17, 9:04 pm 2007
Shannon Nelson
[PATCH 1/5] I/OAT: cleanup pci issues
Reorder the pci release actions Letting go of the resources in the right order helps get rid of occasional kernel complaints. Fix the pci_driver object name [Randy Dunlap] Rename the struct pci_driver data so that false section mismatch warnings won't be produced. Cc: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> --- drivers/dma/ioat.c | 23 ++++++----------------- drivers/dma/ioat_dma.c | 5 ++++- 2 fil...
Oct 17, 9:00 pm 2007
Benjamin Herrenschmidt
[PATCH 0/3] ide: Fix use of paired device
At least 2 drivers (siimage and cs5535) have a bug where they use the construct: ide_drive_t *pair = &hwif->drives[drive->dn ^ 1]; To access the other drive in a master/slave pair. This is bogus because drive->dn is not the unit number, but the global drive number, thus can be 2 & 3 for ide1, 4 & 5 for ide2 etc... This causes the driver to access beyond the drive array into lalaland for any other interface than ide0 and in some case, actually crash :-) These 3 patches f...
Oct 17, 8:56 pm 2007
Benjamin Herrenschmidt
[PATCH 3/3] ide: Fix cs5535 driver accessing beyond array bo...
The cs5535 use an incorrect construct to access the other drive of a pair, causing it to access beyond an array boundary on non-0 interfaces. This fixes it by using the new ide_get_paired_drive() hepler instead. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- drivers/ide/pci/cs5535.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-work/drivers/ide/pci/cs5535.c =================================================================== --- linux-work....
Oct 17, 8:56 pm 2007
Benjamin Herrenschmidt
[PATCH 2/3] ide: Fix siimage driver accessing beyond array b...
The siimage use an incorrect construct to access the other drive of a pair, causing it to access beyond an array boundary on non-0 interfaces. This fixes it by using the new ide_get_paired_drive() hepler instead. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- drivers/ide/pci/siimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-work/drivers/ide/pci/siimage.c =================================================================== --- linux-wo...
Oct 17, 8:56 pm 2007
Benjamin Herrenschmidt
[PATCH 1/3] ide: Add ide_get_paired_drive() helper
This adds a helper to get to the "other" drive on a pair connected to a given hwif. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- Note: You may want to use the 1 - select.b.unit construct instead, as you prefer, I just used what was there and fixed it. include/linux/ide.h | 7 +++++++ 1 file changed, 7 insertions(+) Index: linux-work/include/linux/ide.h =================================================================== --- linux-work.orig/include/linux/ide...
Oct 17, 8:56 pm 2007
Pete Clements
23-git12 Kernel panic blk_rq_map_sg
2.6.23-git12 panics. Here's the short bit EIP:[<c01f5783>] blk_rq_map_sg+073/0x160 SS:ESP 0068:c2dc3df8 Kernel panic - not syncing: Fatal exception in interrupt -- Pete Clements -
Oct 17, 8:35 pm 2007
Al Viro
[git pull] audit patches (first series)
Adds new predicate ("event happened in subtree under <pathname>"). audit-subtree stuff; sat in -mm for several months. Please, pull from git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current.git/ audit.b42 Al Viro <viro@zeniv.linux.org.uk> [PATCH] audit: watching subtrees [PATCH] new helper - inotify_evict_watch() [PATCH] new helper - inotify_clone_watch() [PATCH] new helpers - collect_mounts() and release_collected_mounts() [PATCH] pass dentry to audit_...
Oct 17, 8:37 pm 2007
Robert Hancock
Re: Problem: CPU sleep when calling a function in another o...
Binaries get loaded into memory on demand, so it's quite possible that that part of the executable hasn't been loaded until something calls a function within it. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -
Oct 17, 8:27 pm 2007
Kristen Carlson Accardi
[PATCH] ata: ahci: Enable enclosure management via LED
Enable enclosure management via LED As described in the AHCI spec, some AHCI controllers may support Enclosure management via a variety of protocols. This patch adds support for the LED message type that is specified in AHCI 1.1 and higher. Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com> --- drivers/ata/ahci.c | 153 +++++++++++++++++++++++++++++++++++++++++++++- drivers/ata/libata-scsi.c | 5 - include/linux/libata.h | 3 3 files changed, 15...
Oct 17, 8:24 pm 2007
Shannon Nelson
[PATCH 1/5] I/OAT: cleanup pci issues
Reorder the pci release actions Letting go of the resources in the right order helps get rid of occasional kernel complaints. Fix the pci_driver object name [Randy Dunlap] Rename the struct pci_driver data so that false section mismatch warnings won't be produced. Cc: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> --- drivers/dma/ioat.c | 23 ++++++----------------- drivers/dma/ioat_dma.c | 5 ++++- 2 fil...
Oct 17, 8:14 pm 2007
Shannon Nelson
[PATCH 5/5] I/OAT: Add completion callback for async_tx inte...
The async_tx interface includes a completion callback. This adds support for using that callback, including using interrupts on completion. Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> --- drivers/dma/ioat_dma.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c index 117ac38..f560527 100644 --- a/drivers/dma/ioat_dma.c +++ b/drivers/dma/ioat_dma.c @@ -212,6 +212,18 @@ static dm...
Oct 17, 8:14 pm 2007
Andrew Morton
Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx ...
On Wed, 17 Oct 2007 17:14:39 -0700 Generates a warning on 32-bit: drivers/dma/ioat_dma.c: In function 'ioat_dma_test_callback': drivers/dma/ioat_dma.c:660: warning: cast from pointer to integer of different size and we can never ever print u64's anwyay: we dont' know what type the arch uses to implement them. The usual fix is to cast to unsigned long long, and when I remove this cast I get drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test': drivers/dma/ioat_dma.c:718: warning: assig...
Oct 17, 8:44 pm 2007
David Miller
Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx ...
From: Andrew Morton <akpm@linux-foundation.org> In fact this might crash on systems that conditionally pop return values based upon whether the function is void or not. -
Oct 17, 8:47 pm 2007
Nelson, Shannon
RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx ...
Yep - thanks. That's my misuse of Dan's dma_async_tx_callback typedef. sln -
Oct 17, 8:53 pm 2007
previous daytodaynext day
October 16, 2007October 17, 2007October 18, 2007