Home » Mailing list archives » linux-kernel » 2007 » October » 17

[PATCH 0/3] ide: Fix use of paired device

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Benjamin Herrenschmidt <benh@...>
To: Bartlomiej Zolnierkiewicz <bzolnier@...>
Cc: Linux IDE <linux-ide@...>, <linux-kernel@...>, Andrew Morton <akpm@...>
Subject: [PATCH 0/3] ide: Fix use of paired device
Date: Wednesday, October 17, 2007 - 8:56 pm

At least 2 drivers (siimage and cs5535) have a bug where they use
the construct:

	ide_drive_t *pair	= &hwif->drives[drive->dn ^ 1];

To access the other drive in a master/slave pair. This is bogus
because drive->dn is not the unit number, but the global drive
number, thus can be 2 & 3 for ide1, 4 & 5 for ide2 etc...

This causes the driver to access beyond the drive array into lalaland
for any other interface than ide0 and in some case, actually crash :-)

These 3 patches fix those by introducing a ide_get_paired_drive()
helper that does the right thing and then using it.

Please apply to 2.6.24 if no objection.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] ide: Fix use of paired device, Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 0/3] ide: Fix use of paired device, Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 4:29 pm)
Re: [PATCH 0/3] ide: Fix use of paired device, Sergei Shtylyov, (Thu Oct 18, 7:54 am)
Re: [PATCH 0/3] ide: Fix use of paired device, Benjamin Herrenschmidt, (Thu Oct 18, 8:14 am)
Re: [PATCH 0/3] ide: Fix use of paired device, Sergei Shtylyov, (Thu Oct 18, 7:58 am)
[PATCH 3/3] ide: Fix cs5535 driver accessing beyond array bo..., Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 3/3] ide: Fix cs5535 driver accessing beyond arra..., Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:10 pm)
Re: [PATCH 3/3] ide: Fix cs5535 driver accessing beyond arra..., Sergei Shtylyov, (Thu Oct 18, 8:03 am)
[PATCH 2/3] ide: Fix siimage driver accessing beyond array b..., Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:10 pm)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Sergei Shtylyov, (Thu Oct 18, 8:02 am)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Benjamin Herrenschmidt, (Thu Oct 18, 8:16 am)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:30 pm)
[PATCH 1/3] ide: Add ide_get_paired_drive() helper, Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 1/3] ide: Add ide_get_paired_drive() helper, Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:10 pm)
Re: [PATCH 1/3] ide: Add ide_get_paired_drive() helper, Sergei Shtylyov, (Thu Oct 18, 8:00 am)