Home » Mailing list archives » linux-kernel » 2007 » October » 17

[PATCH 3/3] ide: Fix cs5535 driver accessing beyond array boundary

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Benjamin Herrenschmidt <benh@...>
To: Bartlomiej Zolnierkiewicz <bzolnier@...>
Cc: Linux IDE <linux-ide@...>, <linux-kernel@...>, Andrew Morton <akpm@...>
Subject: [PATCH 3/3] ide: Fix cs5535 driver accessing beyond array boundary
Date: Wednesday, October 17, 2007 - 8:56 pm

The cs5535 use an incorrect construct to access the other drive
of a pair, causing it to access beyond an array boundary on non-0
interfaces. This fixes it by using the new ide_get_paired_drive()
hepler instead.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

 drivers/ide/pci/cs5535.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-work/drivers/ide/pci/cs5535.c
===================================================================
--- linux-work.orig/drivers/ide/pci/cs5535.c	2007-10-18 10:43:39.000000000 +1000
+++ linux-work/drivers/ide/pci/cs5535.c	2007-10-18 10:44:00.000000000 +1000
@@ -84,7 +84,7 @@ static void cs5535_set_speed(ide_drive_t
 
 	/* Set the PIO timings */
 	if ((speed & XFER_MODE) == XFER_PIO) {
-		ide_drive_t *pair = &drive->hwif->drives[drive->dn ^ 1];
+		ide_drive_t *pair = ide_get_paired_drive(drive);
 		u8 cmd, pioa;
 
 		cmd = pioa = speed - XFER_PIO_0;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] ide: Fix use of paired device, Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 0/3] ide: Fix use of paired device, Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 4:29 pm)
Re: [PATCH 0/3] ide: Fix use of paired device, Sergei Shtylyov, (Thu Oct 18, 7:54 am)
Re: [PATCH 0/3] ide: Fix use of paired device, Benjamin Herrenschmidt, (Thu Oct 18, 8:14 am)
Re: [PATCH 0/3] ide: Fix use of paired device, Sergei Shtylyov, (Thu Oct 18, 7:58 am)
[PATCH 3/3] ide: Fix cs5535 driver accessing beyond array bo..., Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 3/3] ide: Fix cs5535 driver accessing beyond arra..., Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:10 pm)
Re: [PATCH 3/3] ide: Fix cs5535 driver accessing beyond arra..., Sergei Shtylyov, (Thu Oct 18, 8:03 am)
[PATCH 2/3] ide: Fix siimage driver accessing beyond array b..., Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:10 pm)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Sergei Shtylyov, (Thu Oct 18, 8:02 am)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Benjamin Herrenschmidt, (Thu Oct 18, 8:16 am)
Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond arr..., Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:30 pm)
[PATCH 1/3] ide: Add ide_get_paired_drive() helper, Benjamin Herrenschmidt, (Wed Oct 17, 8:56 pm)
Re: [PATCH 1/3] ide: Add ide_get_paired_drive() helper, Bartlomiej Zolnierkiewicz..., (Thu Oct 18, 5:10 pm)
Re: [PATCH 1/3] ide: Add ide_get_paired_drive() helper, Sergei Shtylyov, (Thu Oct 18, 8:00 am)