login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
17
RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Nelson, Shannon
Subject:
RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
Date: Wednesday, October 17, 2007 - 5:53 pm
>From: David Miller [mailto:davem@davemloft.net]
quoted text
> >From: Andrew Morton <akpm@linux-foundation.org> >Date: Wed, 17 Oct 2007 17:44:38 -0700 > >> On Wed, 17 Oct 2007 17:14:39 -0700 >> Shannon Nelson <shannon.nelson@intel.com> wrote: >> >> > + tx->callback = (void *)ioat_dma_test_callback; >> >> and when I remove this cast I get >> >> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test': >> drivers/dma/ioat_dma.c:718: warning: assignment from >incompatible pointer type >> >> because ioat_dma_test_callback isn't void-returning. >Something is wrong >> here. I assume that ioat_dma_test_callback() should just be >> void-returning? > >In fact this might crash on systems that conditionally pop >return values based upon whether the function is void or not. >
Yep - thanks. That's my misuse of Dan's dma_async_tx_callback typedef. sln -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 1/5] I/OAT: cleanup pci issues
, Shannon Nelson
, (Wed Oct 17, 5:14 pm)
[PATCH 2/5] I/OAT: clean up of dca provider start and stop
, Shannon Nelson
, (Wed Oct 17, 5:14 pm)
[PATCH 3/5] I/OAT: clean up error handling and some print ...
, Shannon Nelson
, (Wed Oct 17, 5:14 pm)
[PATCH 4/5] I/OAT: Tighten descriptor setup performance
, Shannon Nelson
, (Wed Oct 17, 5:14 pm)
[PATCH 5/5] I/OAT: Add completion callback for async_tx in ...
, Shannon Nelson
, (Wed Oct 17, 5:14 pm)
Re: [PATCH 4/5] I/OAT: Tighten descriptor setup performance
, Andrew Morton
, (Wed Oct 17, 5:34 pm)
Re: [PATCH 5/5] I/OAT: Add completion callback for async_t ...
, Andrew Morton
, (Wed Oct 17, 5:37 pm)
RE: [PATCH 4/5] I/OAT: Tighten descriptor setup performance
, Nelson, Shannon
, (Wed Oct 17, 5:41 pm)
Re: [PATCH 5/5] I/OAT: Add completion callback for async_t ...
, Andrew Morton
, (Wed Oct 17, 5:44 pm)
RE: [PATCH 5/5] I/OAT: Add completion callback for async_t ...
, Nelson, Shannon
, (Wed Oct 17, 5:46 pm)
Re: [PATCH 5/5] I/OAT: Add completion callback for async_t ...
, David Miller
, (Wed Oct 17, 5:47 pm)
RE: [PATCH 5/5] I/OAT: Add completion callback for async_t ...
, Nelson, Shannon
, (Wed Oct 17, 5:53 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 17/36] sysdev: detect multiple driver registrations
Sam Ravnborg
Re: [PATCH] kbuild: fix make V=1
Nick Piggin
Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
Greg Kroah-Hartman
[PATCH 16/36] driver core: cpu: fix section mismatch in cpu.c:store_online
Greg Kroah-Hartman
[PATCH 22/36] PM: Make wakeup flags available whenever CONFIG_PM is set
git
:
Junio C Hamano
Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Mark Burton
Re: [PATCH] builtin-branch: highlight current remote branches with an asterisk
Junio C Hamano
Re: [PATCH 6/6] Teach core object handling functions about gitlinks
Johan Herland
[PATCH 6/7] Softrefs: Administrivia associated with softrefs subsystem and git-sof...
linux-netdev
:
Jarek Poplawski
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
Lennert Buytenhek
Re: Distributed Switch Architecture(DSA)
Daniel Schaffrath
Re: tcp bw in 2.6
Guo-Fu Tseng
Re: jme: UDP checksum error, and lots of them
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
openbsd-misc
:
Conor
Re: RFID Reader
Josh Grosse
ssh/sshd challenge-response seems to have stopped working in -current
Pieter Verberne
File collision while using pkg_add
Stuart Henderson
Re: SquidGuard problem
Community First Financial
Teacher A+ Loan
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
ath9k: Added get_survey callback in order to get channel noise
Linux Kernel Mailing List
ALSA: snd-usb-caiaq: Do not expose hardware input mode 0 of A4DJ
Linux Kernel Mailing List
tracing: protect reader of cmdline output
Linux Kernel Mailing List
kconfig: recalc symbol value before showing search results
Colocation donated by:
Syndicate