RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Nelson, Shannon <shannon.nelson@...>

To: David Miller <davem@...>, <akpm@...>

Cc: <linux-kernel@...>, <torvalds@...>, Williams, Dan J <dan.j.williams@...>, <randy.dunlap@...>

Subject: RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

Date: Wednesday, October 17, 2007 - 8:53 pm

>From: David Miller [mailto:davem@davemloft.net] 
quoted text>
>From: Andrew Morton <akpm@linux-foundation.org>
>Date: Wed, 17 Oct 2007 17:44:38 -0700
>
>> On Wed, 17 Oct 2007 17:14:39 -0700
>> Shannon Nelson <shannon.nelson@intel.com> wrote:
>> 
>> > +	tx->callback = (void *)ioat_dma_test_callback;
>> 
>> and when I remove this cast I get
>> 
>> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test':
>> drivers/dma/ioat_dma.c:718: warning: assignment from 
>incompatible pointer type
>> 
>> because ioat_dma_test_callback isn't void-returning.  
>Something is wrong
>> here.  I assume that ioat_dma_test_callback() should just be
>> void-returning?
>
>In fact this might crash on systems that conditionally pop
>return values based upon whether the function is void or not.
>

Yep - thanks.  That's my misuse of Dan's dma_async_tx_callback typedef.

sln
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/5] I/OAT: cleanup pci issues, Shannon Nelson, (Wed Oct 17, 8:14 pm)

[PATCH 5/5] I/OAT: Add completion callback for async_tx inte..., Shannon Nelson, (Wed Oct 17, 8:14 pm)

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx ..., Andrew Morton, (Wed Oct 17, 8:44 pm)

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx ..., David Miller, (Wed Oct 17, 8:47 pm)

RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx ..., Nelson, Shannon, (Wed Oct 17, 8:53 pm)

Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx ..., Andrew Morton, (Wed Oct 17, 8:37 pm)

RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx ..., Nelson, Shannon, (Wed Oct 17, 8:46 pm)

[PATCH 2/5] I/OAT: clean up of dca provider start and stop, Shannon Nelson, (Wed Oct 17, 8:14 pm)

[PATCH 4/5] I/OAT: Tighten descriptor setup performance, Shannon Nelson, (Wed Oct 17, 8:14 pm)

Re: [PATCH 4/5] I/OAT: Tighten descriptor setup performance, Andrew Morton, (Wed Oct 17, 8:34 pm)

RE: [PATCH 4/5] I/OAT: Tighten descriptor setup performance, Nelson, Shannon, (Wed Oct 17, 8:41 pm)

[PATCH 3/5] I/OAT: clean up error handling and some print me..., Shannon Nelson, (Wed Oct 17, 8:14 pm)


linux-kernel:
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Vladislav Bolkhovitin	Re: Integration of SCST in the mainstream Linux kernel
Andrew Morton	-mm merge plans for 2.6.23
Can E. Acar	Re: Wasting our Freedom
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
PJ Waskiewicz	[ANNOUNCE] ixgbe: Data Center Bridging (DCB) support for ixgbe
openbsd-misc:

RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

Online users