Re: [PATCH 0/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mark Lord <lkml@...>
Cc: <kristen.c.accardi@...>, <linux-kernel@...>, <greg@...>, <pcihpd-discuss@...>, <tytso@...>
Date: Wednesday, October 17, 2007 - 7:25 pm

On Wed, 17 Oct 2007 18:59:43 -0400
Mark Lord <lkml@rtr.ca> wrote:


Please, review http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt -
a lot of experiecne has gone into that...

When preparing patches, always think "how will this appear to someone who
is reading it in the git tree a year from now".

Obviously stuff like "[patch 2/4]" won't be there, because it is
meaningless once the patch hits the git tree.  Also text such as "the previous
patch" and "my patch from yesterday" and "John Doe's comments" and lots of
other stuff which is appropriate to an email conversation is _not_
appropriate to a permanent git commit.


Thanks.  That's much better than having me invent the subject, because when
you choose the title, everyone agrees on what the patch is _called_ (as
long as the title isn't so poorly chosen that I have to fix it).

If the patch title is well-chosen then it becomes a nice google search key,
so if someone wants to find out what we were thinking when we did a
particular patch two years ago, they can just google for the title and go
and read all the email discussion.


Actual code?  That sounds hard ;)
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: PCIe Hotplug: NFG unless I boot with card already inser..., Kristen Carlson Accardi, (Tue Oct 16, 11:46 am)
Re: PCIe Hotplug: NFG unless I boot with card already inser..., Kristen Carlson Accardi, (Tue Oct 16, 4:29 pm)
Re: PCIe Hotplug: NFG unless I boot with card already inser..., Kristen Carlson Accardi, (Tue Oct 16, 2:43 pm)
Re: PCIe Hotplug: NFG unless I boot with card already inser..., Kristen Carlson Accardi, (Tue Oct 16, 4:07 pm)
Re: [PATCH 0/4] Fix PCIe hotplug for non-ACPI ExpressCard sl..., Andrew Morton, (Wed Oct 17, 7:25 pm)
Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non-AC..., Kristen Carlson Accardi, (Wed Oct 17, 7:54 pm)
Re: [PATCH 4/4] Fix PCIe hotplug for non-ACPI ExpressCard sl..., Kristen Carlson Accardi, (Wed Oct 17, 8:01 pm)
Re: [Pcihpd-discuss] [PATCH] Fix PCIe hotplug for Dell noteb..., Kristen Carlson Accardi, (Tue Oct 16, 6:41 pm)
Re: [PATCH] Fix PCIe hotplug for Dell notebook ExpressCard s..., Kristen Carlson Accardi, (Tue Oct 16, 6:04 pm)
Re: PCIe Hotplug: NFG unless I boot with card already inser..., Kristen Carlson Accardi, (Tue Oct 16, 5:01 pm)
Re: PCIe Hotplug: NFG unless I boot with card already inser..., Kristen Carlson Accardi, (Tue Oct 16, 3:51 pm)