Home » Mailing list archives » linux-kernel » 2007 » October » 17

[PATCH] vortex_up should initialize "err"

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Badari Pulavarty <pbadari@...>
To: <netdev@...>
Cc: lkml <linux-kernel@...>
Subject: [PATCH] vortex_up should initialize "err"
Date: Wednesday, October 17, 2007 - 7:15 pm

Simple compile warning fix. (against 2.6.23-git12)

Thanks,
Badari

vortex_up() should initialize 'err' for a successful return.

drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function


Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
---
 drivers/net/3c59x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.23/drivers/net/3c59x.c
===================================================================
--- linux-2.6.23.orig/drivers/net/3c59x.c	2007-10-17 15:33:07.000000000 -0700
+++ linux-2.6.23/drivers/net/3c59x.c	2007-10-17 16:07:10.000000000 -0700
@@ -1491,7 +1491,7 @@ vortex_up(struct net_device *dev)
 	struct vortex_private *vp = netdev_priv(dev);
 	void __iomem *ioaddr = vp->ioaddr;
 	unsigned int config;
-	int i, mii_reg1, mii_reg5, err;
+	int i, mii_reg1, mii_reg5, err = 0;
 
 	if (VORTEX_PCI(vp)) {
 		pci_set_power_state(VORTEX_PCI(vp), PCI_D0);	/* Go active */


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] vortex_up should initialize "err", Badari Pulavarty, (Wed Oct 17, 7:15 pm)
Re: [PATCH] vortex_up should initialize "err", Jeff Garzik, (Wed Oct 17, 8:28 pm)
Re: [PATCH] vortex_up should initialize "err", Steffen Klassert, (Thu Oct 18, 2:05 am)
Re: [PATCH] vortex_up should initialize "err", Andrew Morton, (Thu Oct 18, 2:58 am)