On Wed, Oct 17 2007, Linus Torvalds wrote:
quoted text
> 
> 
> On Wed, 17 Oct 2007, Jens Axboe wrote:
> > 
> > So until that is fixed up, how about this? Should cover all block
> > devices, and I don't think sg_next()/for_each_sg() has spread outside of
> > that yet.
> 
> Heh. Not good. There are drivers that set max phys segmsnts to 1. Either 
> through some host-specific setting (MMC), or explicitly (eg a grep shows 
> viodasd uses just a constant 1 there).

That would hurt... Care to commit your for_each_sg() uglification fixup
for now then? Or disable the allocation debug config entry, so that the
sg+1 deref wont crash? Whichever your prefer, just don't want to cause
crash pains for the unfortunate souls that happen to run into this
before the real fix is done.

-- 
Jens Axboe

-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/