Home » Mailing list archives » linux-kernel » 2007 » October » 17

Re: reduce frequency of cursor blinking

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones <davej@...>
To: Arjan van de Ven <arjan@...>
Cc: Linux Kernel <linux-kernel@...>, Antonino Daplas <adaplas@...>
Subject: Re: reduce frequency of cursor blinking
Date: Wednesday, October 17, 2007 - 3:38 pm

On Tue, Oct 16, 2007 at 11:30:37AM -0700, Arjan van de Ven wrote:
 > On Tue, 16 Oct 2007 14:19:11 -0400
 > Dave Jones <davej@redhat.com> wrote:
 > 
 > > Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
 > 
 > eh no, that's 5 times per second ...

Indeed. Still seems excessive though.
How about twice per second ?

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 73813c6..7d9bae5 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
 	struct fbcon_ops *ops = info->fbcon_par;
 
 	schedule_work(&info->queue);
-	mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+	mod_timer(&ops->cursor_timer, jiffies + HZ/2);
 }
 
 static void fbcon_add_cursor_timer(struct fb_info *info)
-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
reduce frequency of cursor blinking, Dave Jones, (Tue Oct 16, 2:19 pm)
Re: reduce frequency of cursor blinking, Arjan van de Ven, (Tue Oct 16, 2:30 pm)
Re: reduce frequency of cursor blinking, Dave Jones, (Wed Oct 17, 3:38 pm)