Re: [PATCH 2.6.23] SysRq: print hotkey info while pressing undef key, try 2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Yi Yang <yang.y.yi@...>
Cc: <akpm@...>, <crutcher+kernel@...>, <linux-kernel@...>, <mj@...>, <pavel@...>, <schwab@...>
Date: Wednesday, October 17, 2007 - 12:10 pm

Yi Yang wrote:

Wouldn't "Change Loglevel to this value" be more consistent with other
descriptions?
Or maybe even "Change Kernel Loglevel to <value>"; the repeated "this
value" seems somewhat silly.


This is not very descriptive. Maybe "Immediate System Reboot"?


Most descriptions are capitalized. So for consistency this should be
"Trigger a Crashdump". (Although my personal preference would be to drop
the capitalization for all descriptions.)


Should "Regs" be expanded to "Registers"?


For consistency: "Set Keyboard Mode to XLATE"

Cheers,
Frans Pop
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2.6.23] SysRq: print hotkey info while pressing u..., Crutcher Dunnavant, (Wed Oct 24, 2:04 pm)
Re: [PATCH 2.6.23] SysRq: print hotkey info while pressing u..., Frans Pop, (Wed Oct 17, 12:10 pm)