2.6.23-git11 compile issues

Previous thread: [PATCH 2.6.23] SysRq: print hotkey info while pressing undef key, try 2 by Yi Yang on Wednesday, October 17, 2007 - 11:22 am. (8 messages)

Next thread: [bug] block subsystem related crash with latest -git by Ingo Molnar on Wednesday, October 17, 2007 - 11:46 am. (150 messages)
To: lkml <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 11:33 am

To: Badari Pulavarty <pbadari@...>
Cc: lkml <linux-kernel@...>, Andi Kleen <ak@...>
Date: Wednesday, October 17, 2007 - 1:03 pm

I hit the same thing, and fixed it with mrproper as well. I assume this
is a result of the x86 merge.

Andi, is there a way we can detect the old include directories, and
error out? Otherwise, we're going to get a ton more of these reports
when people do incremental patching up to 2.6.24. I've been doing
nightly incremental builds for a year or two, and I think this is the
first time it has actually required manual intervention.

-- Dave

-

To: Dave Hansen <haveblue@...>
Cc: Badari Pulavarty <pbadari@...>, lkml <linux-kernel@...>, Andi Kleen <ak@...>, Thomas Gleixner <tglx@...>, Ingo Molnar <mingo@...>, Andi Kleen <ak@...>
Date: Wednesday, October 17, 2007 - 3:06 pm

Hi Dave.
I cooked up the following patch - can you try it out in your
environment.
I wonder if this is that simple since no-one have done it before??

Sam

diff --git a/Makefile b/Makefile
index ed65de7..136d7c2 100644
--- a/Makefile
+++ b/Makefile
@@ -903,14 +903,24 @@ prepare: prepare0

export CPPFLAGS_vmlinux.lds += -P -C -U$(ARCH)

-# FIXME: The asm symlink changes when $(ARCH) changes. That's
-# hard to detect, but I suppose "make mrproper" is a good idea
-# before switching between archs anyway.
-
-include/asm:
- @echo ' SYMLINK $@ -> include/asm-$(SRCARCH)'
- $(Q)if [ ! -d include ]; then mkdir -p include; fi;
- @ln -fsn asm-$(SRCARCH) $@
+# The asm symlink changes when $(ARCH) changes.
+# Detect this and ask user to run make mrproper
+
+include/asm: FORCE
+ $(Q)set -e; asmlink=`readlink include/asm | cut -d '-' -f 2`; \
+ if [ -L include/asm ]; then \
+ if [ "$$asmlink" != "$(SRCARCH)" ]; then \
+ echo "ERROR: the symlink $@ points to asm-$$asmlink but asm-$(SRCARCH) was expected"; \
+ echo " save .config and run 'make mrproper' to fix it"; \
+ exit 1; \
+ fi; \
+ else \
+ echo ' SYMLINK $@ -> include/asm-$(SRCARCH)'; \
+ if [ ! -d include ]; then \
+ mkdir -p include; \
+ fi; \
+ ln -fsn asm-$(SRCARCH) $@; \
+ fi

# Generate some files
# ---------------------------------------------------------------------------
-

To: Badari Pulavarty <pbadari@...>
Cc: lkml <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 7:43 am

I saw that too after a git pull a couple of days ago.
The following worked for me:

make mrproper
cp /proc/config.gz .config.gz (i was running 2.6.23 release kernel)
gunzip .config.gz
make silentoldconfig
make

regards,

Andre

-

To: Badari Pulavarty <pbadari@...>
Cc: lkml <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 11:38 am

Please try running make mrproper.

/ismail

--
Faith is believing what you know isn't so -- Mark Twain
-

To: Ismail <ismail@...>
Cc: Badari Pulavarty <pbadari@...>, lkml <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 2:48 pm

I found it was enough just to remove the symlink:

rm include/asm

and then build.

Took me longer than it should have to figure out what was going on,
though.

--b.
-

To: Ismail <ismail@...>
Cc: lkml <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 12:17 pm

That fixed it. Thank you.

Thanks,
Badari

-

Previous thread: [PATCH 2.6.23] SysRq: print hotkey info while pressing undef key, try 2 by Yi Yang on Wednesday, October 17, 2007 - 11:22 am. (8 messages)

Next thread: [bug] block subsystem related crash with latest -git by Ingo Molnar on Wednesday, October 17, 2007 - 11:46 am. (150 messages)