Home » Mailing list archives » linux-kernel » 2007 » October » 17

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

Previous thread: [patch] time: introduce xtime_seconds by Ingo Molnar on Tuesday, October 16, 2007 - 10:09 am. (1 message)

Next thread: ioctl32: Unknown cmd by Geert Uytterhoeven on Tuesday, October 16, 2007 - 10:45 am. (6 messages)
[view original message]
From: Joachim Fenkes <fenkes@...>
To: Jeff Garzik <jeff@...>
Cc: Jan-Bernd Themann <THEMANN@...>, Paul Mackerras <paulus@...>, Christoph Raisch <raisch@...>, Hoang-Nam Nguyen <hnguyen@...>, LKML <linux-kernel@...>, LinuxPPC-Dev <linuxppc-dev@...>, Paul Mackerras <pmac@...>, Stefan Roscher <stefan.roscher@...>, Thomas Q Klein <tklein@...>, <netdev@...>, Marcus Eder <meder@...>
Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
Date: Tuesday, October 16, 2007 - 5:20 pm

> >  > responsibility of three different maintainers.
[view original message]
From: Stephen Rothwell <sfr@...>
To: Joachim Fenkes <fenkes@...>
Cc: Jeff Garzik <jeff@...>, Thomas Q Klein <tklein@...>, Jan-Bernd Themann <THEMANN@...>, <netdev@...>, Paul Mackerras <pmac@...>, LKML <linux-kernel@...>, LinuxPPC-Dev <linuxppc-dev@...>, Christoph Raisch <raisch@...>, Marcus Eder <meder@...>, Paul Mackerras <paulus@...>, Stefan Roscher <stefan.roscher@...>
Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
Date: Tuesday, October 16, 2007 - 11:27 am

One small change - I intend to remove the name and owner fields from

struct of_platform_driver, so you should not bother initialising the name

field and just initialise the name field of the embedded struct

device_driver instead.  This, of course, means that you don't need


	drv->driver.name =3D drv->name;


in ibmebus_register_driver.


Sorry for not picking this up earlier.


--=20

Cheers,

Stephen Rothwell                    sfr@canb.auug.org.au

http://www.canb.auug.org.au/~sfr/
[view original message]
From: Joachim Fenkes <fenkes@...>
To: Stephen Rothwell <sfr@...>
Cc: Jeff Garzik <jeff@...>, Thomas Q Klein <tklein@...>, Jan-Bernd Themann <THEMANN@...>, <netdev@...>, Paul Mackerras <pmac@...>, LKML <linux-kernel@...>, LinuxPPC-Dev <linuxppc-dev@...>, Christoph Raisch <raisch@...>, Marcus Eder <meder@...>, Paul Mackerras <paulus@...>, Stefan Roscher <stefan.roscher@...>
Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
Date: Wednesday, October 17, 2007 - 11:21 am

I'd prefer to let this line stay in place until you actually make your

change, to keep the data structures consistent as long as the name field is

present. You could remove it in your patch then.


Regards,

  Joachim


-
[view original message]
From: Jeff Garzik <jeff@...>
To: Joachim Fenkes <fenkes@...>
Cc: Jan-Bernd Themann <THEMANN@...>, Paul Mackerras <paulus@...>, Christoph Raisch <raisch@...>, Hoang-Nam Nguyen <hnguyen@...>, LKML <linux-kernel@...>, LinuxPPC-Dev <linuxppc-dev@...>, Paul Mackerras <pmac@...>, Stefan Roscher <stefan.roscher@...>, Thomas Q Klein <tklein@...>, <netdev@...>, Marcus Eder <meder@...>
Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers
Date: Tuesday, October 16, 2007 - 11:00 am

Fine with me...


	Jeff


-
Previous thread: [patch] time: introduce xtime_seconds by Ingo Molnar on Tuesday, October 16, 2007 - 10:09 am. (1 message)

Next thread: ioctl32: Unknown cmd by Geert Uytterhoeven on Tuesday, October 16, 2007 - 10:45 am. (6 messages)