[PATCH 4/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mark Lord
Date: Tuesday, October 16, 2007 - 6:55 pm

Make use of the previously split out pcie_init_enable_events() function
to reinitialize the hotplug hardware on resume from suspend,
but only when pciehp_force==1.  Otherwise behaviour is unmodified.

Signed-off-by: Mark Lord <mlord@pobox.com>
---
--- old/drivers/pci/hotplug/pciehp_ctrl.c	2007-10-16 21:17:27.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_ctrl.c	2007-10-16 21:28:36.000000000 -0400
@@ -37,7 +37,6 @@
 #include "pciehp.h"
 
 static void interrupt_event_handler(struct work_struct *work);
-static int pciehp_disable_slot(struct slot *p_slot);
 
 static int queue_interrupt_event(struct slot *p_slot, u32 event_type)
 {
--- old/drivers/pci/hotplug/pciehp.h	2007-10-16 21:17:27.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp.h	2007-10-16 21:28:42.000000000 -0400
@@ -162,6 +162,8 @@
 extern void pciehp_queue_pushbutton_work(struct work_struct *work);
 int pcie_init(struct controller *ctrl, struct pcie_device *dev);
 int pciehp_enable_slot(struct slot *p_slot);
+int pciehp_disable_slot(struct slot *p_slot);
+int pcie_init_enable_events(struct controller *ctrl, struct pcie_device *dev);
 
 static inline struct slot *pciehp_find_slot(struct controller *ctrl, u8 device)
 {
--- old/drivers/pci/hotplug/pciehp_core.c	2007-10-16 21:17:27.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_core.c	2007-10-16 21:30:19.000000000 -0400
@@ -512,6 +512,24 @@
 static int pciehp_resume (struct pcie_device *dev)
 {
 	printk("%s ENTRY\n", __FUNCTION__);	
+	if (pciehp_force) {
+		struct pci_dev *pdev = dev->port;
+		struct controller *ctrl = pci_get_drvdata(pdev);
+		struct slot *t_slot;
+		u8 status;
+
+		/* reinitialize the chipset's event detection logic */
+		pcie_init_enable_events(ctrl, dev);
+
+		t_slot = pciehp_find_slot(ctrl, ctrl->slot_device_offset);
+
+		/* Check if slot is occupied */
+		t_slot->hpc_ops->get_adapter_status(t_slot, &status);
+		if (status)
+			pciehp_enable_slot(t_slot);
+		else
+			pciehp_disable_slot(t_slot);
+	}
 	return 0;
 }
 #endif
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: PCIe Hotplug: NFG unless I boot with card already ins ..., Kristen Carlson Accardi, (Tue Oct 16, 8:46 am)
Re: PCIe Hotplug: NFG unless I boot with card already ins ..., Kristen Carlson Accardi, (Tue Oct 16, 11:43 am)
Re: PCIe Hotplug: NFG unless I boot with card already ins ..., Kristen Carlson Accardi, (Tue Oct 16, 12:51 pm)
Re: PCIe Hotplug: NFG unless I boot with card already ins ..., Kristen Carlson Accardi, (Tue Oct 16, 1:07 pm)
Re: PCIe Hotplug: NFG unless I boot with card already ins ..., Kristen Carlson Accardi, (Tue Oct 16, 1:29 pm)
Re: PCIe Hotplug: NFG unless I boot with card already ins ..., Kristen Carlson Accardi, (Tue Oct 16, 2:01 pm)
Re: [PATCH] Fix PCIe hotplug for Dell notebook ExpressCard ..., Kristen Carlson Accardi, (Tue Oct 16, 3:04 pm)
Re: [Pcihpd-discuss] [PATCH] Fix PCIe hotplug for Dell not ..., Kristen Carlson Accardi, (Tue Oct 16, 3:41 pm)
[PATCH 4/4] Fix PCIe hotplug for non-ACPI ExpressCard slot ..., Mark Lord, (Tue Oct 16, 6:55 pm)
Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non- ..., Kristen Carlson Accardi, (Wed Oct 17, 4:54 pm)
Re: [PATCH 4/4] Fix PCIe hotplug for non-ACPI ExpressCard ..., Kristen Carlson Accardi, (Wed Oct 17, 5:01 pm)