Re: [PATCH] Map volume and brightness events on thinkpads

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Dmitry Torokhov <dmitry.torokhov@...>
Cc: Matthew Garrett <mjg59@...>, Henrique de Moraes Holschuh <hmh@...>, Jeremy Katz <katzj@...>, <linux-kernel@...>, <davej@...>
Date: Tuesday, October 16, 2007 - 4:32 pm

On Tue, 16 Oct 2007, Dmitry Torokhov wrote:

Well, I'd argue that:

 - it's going to be the same entity that cares in both cases (ie anybody 
   who is ready to accept VOLUME_UP keypresses is also the exact same 
   party that also wants to know if VOLUME_UP happened *independently*)

   Ergo: making it a separate "generic" notification is actually totally 
   counterproductive, because it just adds complexity.

 - it really is a keypress. Yes, it's a keypress with side effects, but 
   it still tends to have a distinct source, and as such it is interesting 
   *as* a keypress. 

   IOW: it should have all the same "incidental" side effects as any other 
   keypress. Example: I think it's reasonable to consider it an event as 
   far as the screen saver is concerned. In other words, it's not *just* a 
   "volume was raised" event. It's a "volume was raised, and the user 
   actually pressed a key to do so".

So I do think they are keypresses, although I also suspect that like many 
other magical keys, the "NOTIFY" version is often also totally hidden by 
hardware/firmware interactions (ie I'm pretty sure that many of those 
special keys will never be visible at all to the OS, because the firmware 
hides the fact that they were pressed entirely!)

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Map volume and brightness events on thinkpads, Jeremy Katz, (Mon Oct 15, 4:45 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 2:53 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Renato S. Yamane, (Tue Oct 16, 3:23 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Mon Oct 15, 5:07 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 9:00 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 10:11 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 10:27 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 10:54 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 11:54 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 11:59 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 10:21 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 10:31 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 10:40 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 12:56 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 2:46 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Linus Torvalds, (Tue Oct 16, 3:14 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 4:12 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Linus Torvalds, (Tue Oct 16, 4:32 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Wed Oct 17, 11:57 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Wed Oct 17, 12:28 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 1:35 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Wed Oct 17, 2:59 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 4:42 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Thu Oct 18, 10:37 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Thu Oct 18, 6:39 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 23, 11:54 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 23, 7:34 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 4:55 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 5:18 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 4:19 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 3:20 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 4:02 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 4:15 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Jesse Barnes, (Mon Oct 15, 11:38 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 4:36 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 5:18 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Jesse Barnes, (Tue Oct 16, 10:40 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 2:25 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 2:39 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Arjan van de Ven, (Mon Oct 15, 5:43 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 5:12 am)