Home » Mailing list archives » linux-kernel » 2007 » October » 16

Re: [PATCH] Map volume and brightness events on thinkpads

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Henrique de Moraes Holschuh <hmh@...>
To: Jesse Barnes <jesse.barnes@...>
Cc: Jeremy Katz <katzj@...>, <linux-kernel@...>, <torvalds@...>, <davej@...>
Subject: Re: [PATCH] Map volume and brightness events on thinkpads
Date: Tuesday, October 16, 2007 - 4:36 am

On Mon, 15 Oct 2007, Jesse Barnes wrote:

This is not an option on IBM ThinkPads, unless you patch the DSDT on
non-ancient ACPI-based models, and unless you patch the BIOS (and maybe even
the EC control program) itself on the really ancient models.  It is that
simple.

On *new* Lenovo ThinkPad BIOSes (the z60 that Lenovo has given up on act
just like IBM ThinkPads), the firmware reports brightness changes through
the proper ACPI messages, which are processed by the ACPI video module. So I
will repeat myself here: brightness control is to be processed by the ACPI
video module, so brightness hot keys are not to be reported by default in
Lenovo thinkpads.

You want ACPI video to just pass the messages to userspace when X.org is
driving the backlight?  Fine with me.  That *still* doesn't make it right to
get these messages as hot key presses over the input layer through the
thinkpad-acpi driver.  So the NAK stands.  Any changes should be done to the
ACPI video driver in this case.

If the user has any real need to get these messages from thinkpad-acpi for
whichever particular reasons, he can use the standard interface to input
event drivers to remap the scan codes to whatever he wants.


Good luck, and please interface it properly to the backlight class while
at it.  There's no reason to make the waters mudier :-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Map volume and brightness events on thinkpads, Jeremy Katz, (Mon Oct 15, 4:45 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 2:53 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Renato S. Yamane, (Tue Oct 16, 3:23 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Mon Oct 15, 5:07 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 9:00 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 10:11 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 10:27 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 10:54 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 11:54 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 11:59 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 10:21 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 10:31 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 10:40 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 12:56 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 2:46 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Linus Torvalds, (Tue Oct 16, 3:14 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dave Airlie, (Tue Oct 16, 4:32 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 4:12 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Linus Torvalds, (Tue Oct 16, 4:32 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Wed Oct 17, 11:57 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Wed Oct 17, 12:28 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 1:35 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Wed Oct 17, 2:59 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 4:42 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Thu Oct 18, 10:37 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Thu Oct 18, 6:39 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 23, 11:54 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 23, 7:34 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Kok, Auke, (Tue Oct 16, 4:48 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 4:55 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 5:18 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Jeremy Katz, (Tue Oct 16, 4:11 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 4:19 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Matthew Garrett, (Tue Oct 16, 3:20 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 4:02 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Dmitry Torokhov, (Tue Oct 16, 4:15 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Jesse Barnes, (Mon Oct 15, 11:38 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 4:36 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Jesse Barnes, (Tue Oct 16, 4:49 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 5:18 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Jesse Barnes, (Tue Oct 16, 10:40 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 2:25 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Jesse Barnes, (Wed Oct 17, 2:32 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Wed Oct 17, 2:39 am)
Re: [PATCH] Map volume and brightness events on thinkpads, Arjan van de Ven, (Mon Oct 15, 5:43 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Jeremy Katz, (Mon Oct 15, 5:27 pm)
Re: [PATCH] Map volume and brightness events on thinkpads, Henrique de Moraes Holschuh..., (Tue Oct 16, 5:12 am)