Re: [patch] forcedeth: fix the NAPI poll function

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Jeff Garzik <jeff@...>

Cc: David Miller <davem@...>, <linux-kernel@...>, <torvalds@...>, <shemminger@...>

Subject: Re: [patch] forcedeth: fix the NAPI poll function

Date: Tuesday, October 16, 2007 - 3:49 am

* Jeff Garzik <jeff@garzik.org> wrote:

quoted text> >FYI, looks good so far, ontop of Linus' latest -git tree.
> >
> >btw., one thing i always found weird about forcedeth is that it 
> >generates an extra ~100 irqs per second even when there's no network 
> >traffic:
> >
> > 11:      89752    XT-PIC-XT        eth0
> > 11:      89854    XT-PIC-XT        eth0
> > 11:      89955    XT-PIC-XT        eth0
> > 11:      90056    XT-PIC-XT        eth0
> > 11:      90157    XT-PIC-XT        eth0
> >
> >(irq count snapshot every second). Just in case it's easy to fix ...
> 
> 
> May I presume that behavior occurs in both mainline and my fe-lock 
> branch?

correct.

quoted text> That is likely the NIC's timer irq, which is programmed to kick the 
> irq handler every so often.  DEV_NEED_TIMERIRQ is a starting point, as 
> well as "Known bugs" at the top of forcedeth.c, if you're curious.
> 
> I'm _betting_ that some of that can be eliminated, but we'll see...

ok. Was just a FYI - you were looking for feedback :-)

	Ingo
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 7:24 am)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 3:57 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 6:03 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Jeff Garzik, (Mon Oct 15, 6:20 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 6:18 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 6:07 pm)

[patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Mon Oct 15, 6:30 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 5:20 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Wed Oct 17, 3:25 am)

[patch] forcedeth: fix the NAPI poll function, take #2, Ingo Molnar, (Wed Oct 17, 6:18 am)

Re: [patch] forcedeth: fix the NAPI poll function, take #2, Jeff Garzik, (Wed Oct 17, 8:21 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Mon Oct 15, 6:40 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 1:42 am)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 1:47 am)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 2:40 am)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 3:17 am)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 3:49 am)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 12:52 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Mon Oct 15, 6:41 pm)

Re: [patch] forcedeth: fix the NAPI poll function, David Miller, (Mon Oct 15, 6:39 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 6:21 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 7:27 am)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 12:18 pm)


linux-kernel:
David Miller	Re: Slow DOWN, please!!!
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Heiko Carstens	Re: -mm merge plans for 2.6.23 -- sys_fallocate
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Jan Engelhardt	Re: iptables very slow after commit 784544739a25c30637397ace5489eeb6e15d7d49
openbsd-misc:

Re: [patch] forcedeth: fix the NAPI poll function

Online users