login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
15
Re: [PATCH 4/11] maps3: introduce a generic page walker
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Matt Mackall
Subject:
Re: [PATCH 4/11] maps3: introduce a generic page walker
Date: Monday, October 15, 2007 - 4:30 pm
On Mon, Oct 15, 2007 at 03:40:27PM -0700, Jeremy Fitzhardinge wrote:
quoted text
> Matt Mackall wrote: > > Introduce a general page table walker > > > > Definitely approve in principle, but some comments: > > > Signed-off-by: Matt Mackall <mpm@selenic.com> > > > > Index: l/include/linux/mm.h > > =================================================================== > > --- l.orig/include/linux/mm.h 2007-10-09 17:37:59.000000000 -0500 > > +++ l/include/linux/mm.h 2007-10-10 11:46:37.000000000 -0500 > > @@ -773,6 +773,17 @@ unsigned long unmap_vmas(struct mmu_gath > > struct vm_area_struct *start_vma, unsigned long start_addr, > > unsigned long end_addr, unsigned long *nr_accounted, > > struct zap_details *); > > + > > +struct mm_walk { > > + int (*pgd_entry)(pgd_t *, unsigned long, unsigned long, void *); > > + int (*pud_entry)(pud_t *, unsigned long, unsigned long, void *); > > + int (*pmd_entry)(pmd_t *, unsigned long, unsigned long, void *); > > + int (*pte_entry)(pte_t *, unsigned long, unsigned long, void *); > > + int (*pte_hole) (unsigned long, unsigned long, void *); > > +}; > > > > It would be nice to have some clue about when each of these functions > are called (depth first? pre or post order?), and what their params > are. Does it call a callback for folded pagetable levels? > > Can pte_hole be used to create new mappings while we're traversing the > pagetable? Apparently not, because it continues after calling it. > > > + > > +int walk_page_range(struct mm_struct *, unsigned long addr, unsigned long end, > > + struct mm_walk *walk, void *private); > > void free_pgd_range(struct mmu_gather **tlb, unsigned long addr, > > unsigned long end, unsigned long floor, unsigned long ceiling); > > void free_pgtables(struct mmu_gather **tlb, struct vm_area_struct *start_vma, > > Index: l/mm/Makefile > > =================================================================== > > --- l.orig/mm/Makefile 2007-10-09 17:37:59.000000000 -0500 > > +++ l/mm/Makefile 2007-10-10 11:46:37.000000000 -0500 > > @@ -5,7 +5,7 @@ > > mmu-y := nommu.o > > mmu-$(CONFIG_MMU) := fremap.o highmem.o madvise.o memory.o mincore.o \ > > mlock.o mmap.o mprotect.o mremap.o msync.o rmap.o \ > > - vmalloc.o > > + vmalloc.o pagewalk.o > > > > obj-y := bootmem.o filemap.o mempool.o oom_kill.o fadvise.o \ > > page_alloc.o page-writeback.o pdflush.o \ > > Index: l/mm/pagewalk.c > > =================================================================== > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > > +++ l/mm/pagewalk.c 2007-10-10 11:46:37.000000000 -0500 > > @@ -0,0 +1,120 @@ > > +#include <linux/mm.h> > > +#include <linux/highmem.h> > > +#include <linux/sched.h> > > + > > +static int walk_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > > + struct mm_walk *walk, void *private) > > +{ > > + pte_t *pte; > > + int err = 0; > > + > > + pte = pte_offset_map(pmd, addr); > > + do { > > + err = walk->pte_entry(pte, addr, addr, private); > > > > Should this be (pte, addr, addr+PAGE_SIZE, private)?
Probably - the pattern is [start, end). Either that or we should have one arg.
quoted text
> > +/* > > + * walk_page_range - walk a memory map's page tables with a callback > > + * @mm - memory map to walk > > + * @addr - starting address > > + * @end - ending address > > + * @walk - set of callbacks to invoke for each level of the tree > > + * @private - private data passed to the callback function > > + * > > + * Recursively walk the page table for the memory area in a VMA, calling > > + * a callback for every bottom-level (PTE) page table. > > > > It calls a callback for every level of the pagetable.
Oops. -- Mathematics is the supreme nostalgia of our time. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/11] maps3: pagemap monitoring v3
, Matt Mackall
, (Mon Oct 15, 3:25 pm)
[PATCH 1/11] maps3: add proportional set size accounting i ...
, Matt Mackall
, (Mon Oct 15, 3:25 pm)
[PATCH 2/11] maps3: introduce task_size_of for all arches
, Matt Mackall
, (Mon Oct 15, 3:25 pm)
[PATCH 3/11] maps3: move is_swap_pte
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 4/11] maps3: introduce a generic page walker
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 5/11] maps3: use pagewalker in clear_refs and smaps
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 6/11] maps3: simplify interdependence of maps and smaps
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 7/11] maps3: move clear_refs code to task_mmu.c
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 8/11] maps3: regroup task_mmu by interface
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 9/11] maps3: add /proc/pid/pagemap interface
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 10/11] maps3: add /proc/kpagecount and /proc/kpagef ...
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
[PATCH 11/11] maps3: make page monitoring /proc file optional
, Matt Mackall
, (Mon Oct 15, 3:26 pm)
Re: [PATCH 4/11] maps3: introduce a generic page walker
, Jeremy Fitzhardinge
, (Mon Oct 15, 3:40 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Dave Hansen
, (Mon Oct 15, 3:48 pm)
Re: [PATCH 11/11] maps3: make page monitoring /proc file o ...
, Dave Hansen
, (Mon Oct 15, 3:49 pm)
Re: [PATCH 11/11] maps3: make page monitoring /proc file o ...
, Jeremy Fitzhardinge
, (Mon Oct 15, 3:51 pm)
Re: [PATCH 4/11] maps3: introduce a generic page walker
, Dave Hansen
, (Mon Oct 15, 4:05 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Matt Mackall
, (Mon Oct 15, 4:11 pm)
Re: [PATCH 4/11] maps3: introduce a generic page walker
, Jeremy Fitzhardinge
, (Mon Oct 15, 4:20 pm)
Re: [PATCH 4/11] maps3: introduce a generic page walker
, Matt Mackall
, (Mon Oct 15, 4:30 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Dave Hansen
, (Mon Oct 15, 4:34 pm)
Re: [PATCH 1/11] maps3: add proportional set size accounti ...
, David Rientjes
, (Mon Oct 15, 4:36 pm)
Re: [PATCH 2/11] maps3: introduce task_size_of for all arches
, David Rientjes
, (Mon Oct 15, 4:45 pm)
Re: [PATCH 11/11] maps3: make page monitoring /proc file o ...
, Rusty Russell
, (Mon Oct 15, 5:03 pm)
Re: [PATCH 1/11] maps3: add proportional set size accounti ...
, Matt Mackall
, (Mon Oct 15, 5:18 pm)
Re: [PATCH 11/11] maps3: make page monitoring /proc file o ...
, Matt Mackall
, (Mon Oct 15, 5:20 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Matt Mackall
, (Mon Oct 15, 5:35 pm)
Re: [PATCH 2/11] maps3: introduce task_size_of for all arches
, Dave Hansen
, (Mon Oct 15, 5:36 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Dave Hansen
, (Mon Oct 15, 5:49 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Matt Mackall
, (Mon Oct 15, 5:58 pm)
Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kp ...
, Dave Hansen
, (Mon Oct 15, 6:07 pm)
Re: [PATCH 1/11] maps3: add proportional set size accounti ...
, David Rientjes
, (Mon Oct 15, 7:24 pm)
Re: [PATCH 2/11] maps3: introduce task_size_of for all arches
, David Rientjes
, (Mon Oct 15, 7:26 pm)
Re: [PATCH 4/11] maps3: introduce a generic page walker
, David Rientjes
, (Mon Oct 15, 9:58 pm)
Re: [PATCH 5/11] maps3: use pagewalker in clear_refs and smaps
, David Rientjes
, (Mon Oct 15, 10:03 pm)
Re: [PATCH 7/11] maps3: move clear_refs code to task_mmu.c
, David Rientjes
, (Mon Oct 15, 10:11 pm)
Re: [PATCH 11/11] maps3: make page monitoring /proc file o ...
, David Rientjes
, (Mon Oct 15, 10:25 pm)
maps3: introduce task_size_of for all arches (updated v4)
, Dave Hansen
, (Tue Oct 16, 10:18 am)
Re: maps3: introduce task_size_of for all arches (updated v4)
, David Rientjes
, (Tue Oct 16, 10:25 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Christoph Lameter
[PATCH 1/2] Make page->private usable in compound pages V1
Luben Tuikov
Re: Integration of SCST in the mainstream Linux kernel
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michal Nazarewicz
Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Jesse Barnes
Re: PCI probing changes
git
:
Jakub Narebski
Re: GSoC 2008 - Mentors Wanted!
Jan Harkes
Re: git-svn and huge data and modifying the git-svn-HEAD branch directly
Andy Parkins
git-fetch fails with error code 128
Marcus Griep
Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Junio C Hamano
Re: [JGIT PATCH 2/2] Decrease the fetch pack client buffer to the lower minimum
git-commits-head
:
Linux Kernel Mailing List
ARM: 5970/1: nomadik-gpio: fix spinlock usage
Linux Kernel Mailing List
sh-sci: update receive error handling for muxed irqs
Linux Kernel Mailing List
No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List
x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List
Input: gpio-keys - add support for disabling gpios through sysfs
linux-netdev
:
Eric Dumazet
[PATCH] net: ALIGN/PTR_ALIGN cleanup in alloc_netdev_mq()/netdev_priv()
Patrick McHardy
[NET_SCHED]: sch_ingress: remove netfilter support
Rose, Gregory V
RE: __bad_udelay in network driver breaks build
Patrick McHardy
Re: no reassembly for outgoing packets on RAW socket
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
ropers
Re: Real men don't attack straw men
elitdostlar
Seks partneri arayan bayanlar bu adreste - 8878xs706x6438
Marcus Andree
Re: This is what Linus Torvalds calls openBSD crowd
Lars D. Noodén
Re: sshd.config and AllowUsers
Henning Brauer
Re: Sun Blade 1000?
Colocation donated by:
Syndicate