Re: [patch] forcedeth: fix the NAPI poll function

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: <mingo@...>

Cc: <linux-kernel@...>, <torvalds@...>, <shemminger@...>, <jgarzik@...>

Subject: Re: [patch] forcedeth: fix the NAPI poll function

Date: Monday, October 15, 2007 - 6:39 pm

From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 16 Oct 2007 00:30:09 +0200

quoted text> Subject: forcedeth: fix the NAPI poll function
> From: Ingo Molnar <mingo@elte.hu>
> 
> fix the forcedeth NAPI poll function to not emit this warning:
> 
> [  186.635916] WARNING: at net/core/dev.c:2166 net_rx_action()
> [  186.641351]  [<c060d9f5>] net_rx_action+0x145/0x1b0
> [  186.646191]  [<c011d752>] __do_softirq+0x42/0x90
> [  186.650784]  [<c011d7c6>] do_softirq+0x26/0x30
> [  186.655202]  [<c011db48>] local_bh_enable+0x48/0xa0
> [  186.660055]  [<c06023e0>] lock_sock_nested+0xa0/0xc0
> [  186.664995]  [<c065da16>] tcp_recvmsg+0x16/0xbc0
> [  186.669588]  [<c013e94b>] __generic_file_aio_write_nolock+0x27b/0x520
> [  186.676001]  [<c0601d75>] sock_common_recvmsg+0x45/0x70
> [  186.681202]  [<c05ff5df>] sock_aio_read+0x11f/0x140
> [  186.686054]  [<c015c086>] do_sync_read+0xc6/0x110
> [  186.690735]  [<c012b9b0>] autoremove_wake_function+0x0/0x40
> [  186.696280]  [<c060dcfc>] net_tx_action+0x3c/0xe0
> [  186.700961]  [<c015c9c2>] vfs_read+0x132/0x140
> [  186.705378]  [<c015cd41>] sys_read+0x41/0x70
> [  186.709625]  [<c0102b66>] sysenter_past_esp+0x5f/0x89
> [  186.714651]  =======================
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>

Excellent catch:

Acked-by: David S. Miller <davem@davemloft.net>
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 7:24 am)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 3:57 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 6:03 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Jeff Garzik, (Mon Oct 15, 6:20 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 6:18 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 6:07 pm)

[patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Mon Oct 15, 6:30 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 5:20 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Wed Oct 17, 3:25 am)

[patch] forcedeth: fix the NAPI poll function, take #2, Ingo Molnar, (Wed Oct 17, 6:18 am)

Re: [patch] forcedeth: fix the NAPI poll function, take #2, Jeff Garzik, (Wed Oct 17, 8:21 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Mon Oct 15, 6:40 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 1:42 am)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 1:47 am)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 2:40 am)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 3:17 am)

Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 3:49 am)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 12:52 pm)

Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Mon Oct 15, 6:41 pm)

Re: [patch] forcedeth: fix the NAPI poll function, David Miller, (Mon Oct 15, 6:39 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 6:21 pm)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 7:27 am)

Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 12:18 pm)


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Andrew Morton	2.6.23-rc6-mm1
Eric Paris	[RFC 0/5] [TALPA] Intro to a linux interface for on access scanning
linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Natalie Protasevich	[BUG] New Kernel Bugs
git:

openbsd-misc: