Re: WARNING: at net/core/dev.c:2161 net_rx_action()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: <linux-kernel@...>, <torvalds@...>, <shemminger@...>, Jeff Garzik <jgarzik@...>
Date: Monday, October 15, 2007 - 6:03 pm

* David Miller <davem@davemloft.net> wrote:


it's forcedeth.

i've checked nv_napi_poll(), and i dont see how it could return larger 
than 'limit' number of packets.

it could return packets == limit though:

                pkts = nv_rx_process_optimized(dev, budget);
...

        if (pkts < budget) {
                /* re-enable receive interrupts */
                spin_lock_irqsave(&np->lock, flags);

                __netif_rx_complete(dev, napi);

...
        return pkts;

shouldnt that be "pkts <= budget"? But even that shouldnt cause a larger 
than limit return. Weird.

there are two networking cards in the system, the other one is a:

  eth1: RealTek RTL8139 at 0xf080e000, 00:c0:df:03:68:5d, IRQ 11
  eth1:  Identified 8139 chip type 'RTL-8139B'

but this one should be inactive (not plugged into the network). Should i 
try to get a debug print out of the actual 'weight' and 'work' integers, 
and of the n->poll function address?

	Ingo
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 7:24 am)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 3:57 pm)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 6:03 pm)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Jeff Garzik, (Mon Oct 15, 6:20 pm)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 6:18 pm)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 6:07 pm)
[patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Mon Oct 15, 6:30 pm)
Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 5:20 pm)
Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Wed Oct 17, 3:25 am)
[patch] forcedeth: fix the NAPI poll function, take #2, Ingo Molnar, (Wed Oct 17, 6:18 am)
Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Mon Oct 15, 6:40 pm)
Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 1:42 am)
Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 1:47 am)
Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 2:40 am)
Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 3:17 am)
Re: [patch] forcedeth: fix the NAPI poll function, Ingo Molnar, (Tue Oct 16, 3:49 am)
Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Tue Oct 16, 12:52 pm)
Re: [patch] forcedeth: fix the NAPI poll function, Jeff Garzik, (Mon Oct 15, 6:41 pm)
Re: [patch] forcedeth: fix the NAPI poll function, David Miller, (Mon Oct 15, 6:39 pm)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), David Miller, (Mon Oct 15, 6:21 pm)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 7:27 am)
Re: WARNING: at net/core/dev.c:2161 net_rx_action(), Ingo Molnar, (Mon Oct 15, 12:18 pm)