Re: [git pull] scheduler updates for v2.6.24

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Monday, October 15, 2007 - 11:53 am

* Andrew Morton <akpm@linux-foundation.org> wrote:


yes - that crash was a showstopper that was holding up the pull request 
for 2 days. Paul bisected it down to the culprit and the fix was to do 
this in wake_up_new_task():

-       if (!p->sched_class->task_new || !current->se.on_rq) {
+       if (!p->sched_class->task_new || !current->se.on_rq || !rq->cfs.curr) {

(during early bootup the cfs_rq has no curr pointer yet.) It's not clear 
why this race did not trigger earlier. (and the two checks can probably 
be consolidated into a single "!rq->cfs.curr" condition.)

	Ingo
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] scheduler updates for v2.6.24, Ingo Molnar, (Mon Oct 15, 7:17 am)
Re: [git pull] scheduler updates for v2.6.24, Ingo Molnar, (Mon Oct 15, 8:04 am)
Re: [git pull] scheduler updates for v2.6.24, Andrew Morton, (Mon Oct 15, 11:35 am)
Re: [git pull] scheduler updates for v2.6.24, Ingo Molnar, (Mon Oct 15, 11:53 am)
Re: [git pull] scheduler updates for v2.6.24, Nick Piggin, (Mon Oct 15, 7:38 pm)
Re: [git pull] scheduler updates for v2.6.24, Thomas Backlund, (Tue Oct 16, 3:04 am)
Re: [git pull] scheduler updates for v2.6.24, Ingo Molnar, (Tue Oct 16, 3:08 am)
Re: [git pull] scheduler updates for v2.6.24, Ingo Molnar, (Tue Oct 16, 3:12 am)
Re: [git pull] scheduler updates for v2.6.24, Thomas Backlund, (Tue Oct 16, 4:00 am)
Re: [git pull] scheduler updates for v2.6.24, Gabriel C, (Tue Oct 16, 3:13 pm)
Re: [git pull] scheduler updates for v2.6.24, Dmitry Adamushko, (Tue Oct 16, 3:38 pm)
Re: [git pull] scheduler updates for v2.6.24, Dmitry Adamushko, (Tue Oct 16, 4:31 pm)
Re: [git pull] scheduler updates for v2.6.24, Gabriel C, (Tue Oct 16, 4:50 pm)