Home » Mailing list archives » linux-kernel » 2007 » October » 15

Re: [PATCH][try 2] architectural pstate driver for powernow-k8

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones
Subject: Re: [PATCH][try 2] architectural pstate driver for powernow-k8
Date: Monday, October 15, 2007 - 8:40 am

On Thu, Oct 11, 2007 at 08:59:58AM +0100, Andy Whitcroft wrote:
 
 > >  	/* get fid did for hardware pstate transition */
 > >  	pstate = index & HW_PSTATE_MASK;
 > > -	if (pstate > MAX_HW_PSTATE)
 > > +	if (pstate > data->max_hw_pstate);
 > >  		return 0;
 > 
 > checkpatch picked up this dodgy if.  I suspect that the ';' is wrong
 > from the context.
 
Indeed.  Mark/Andreas, want to send me a new patch against latest
Linus HEAD ?  I didn't apply the old one yet, as it conflicted with
the changes already queued for merging.

Thanks,

	Dave

-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] architectural pstate driver for powernow-k8, Mark Langsdorf, (Tue Oct 9, 12:46 pm)
Re: [PATCH] architectural pstate driver for powernow-k8, Andi Kleen, (Tue Oct 9, 1:06 pm)
[PATCH][try 2] architectural pstate driver for powernow-k8, Mark Langsdorf, (Tue Oct 9, 1:43 pm)
Re: [PATCH][try 2] architectural pstate driver for powernow-k8, Dave Jones, (Tue Oct 9, 4:41 pm)
Re: [PATCH][try 2] architectural pstate driver for powernow-k8, Andreas Herrmann3, (Wed Oct 10, 9:35 am)
RE: [PATCH][try 2] architectural pstate driver for powernow-k8, Langsdorf, Mark, (Wed Oct 10, 10:06 am)
Re: [PATCH][try 2] architectural pstate driver for powernow-k8, Andy Whitcroft, (Thu Oct 11, 12:59 am)
Re: [PATCH][try 2] architectural pstate driver for powernow-k8, Dave Jones, (Mon Oct 15, 8:40 am)
[PATCH][try 3] architectural pstate driver for powernow-k8, Mark Langsdorf, (Mon Oct 15, 9:23 am)
Re: [PATCH][try 3] architectural pstate driver for powernow-k8, Dave Jones, (Mon Oct 15, 1:32 pm)
Re: [PATCH][try 4] architectural pstate driver for powernow-k8, Mark Langsdorf, (Mon Oct 15, 2:03 pm)
Re: [PATCH][try 4] architectural pstate driver for powernow-k8, Dave Jones, (Wed Oct 17, 2:33 pm)