Avi Kivity wrote:
quoted text
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>> =20
>>> Ingo Molnar wrote:
>>>   =20
>>>> * Avi Kivity <avi@qumranet.com> wrote:
>>>>
>>>> =20
>>>>     =20
>>>>> This bit can go; for the external module I can add it back in
>>>>> external-module-compat.h.  No need to pollute mainline with backwar=
d
quoted text
>>>>> compatibility stuff.
>>>>>            =20
>>>> hm:
>>>>
>>>> static inline void kvm_guest_enter(void)
>>>> {
>>>>         current->flags |=3D PF_VCPU;
>>>> }
>>>>
>>>> static inline void kvm_guest_exit(void)
>>>> {
>>>> }
>>>>
>>>> shouldnt PF_VCPU be cleared in kvm_guest_exit()?
>>>>        =20
>>> IIRC the accounting code clears it, but yes, it may not have been cal=
led
quoted text
>>> at all, so clearing it here is needed.
>>>
>>>    =20
>>
>> No, It must not be cleared here because we can't enter in the
>> accounting code
>> between kvm_guest_enter(void) and kvm_guest_exit(void).
>>
>>  =20
>=20
> Right.
>=20
>> This is why the accounting code clears it.
>>  =20
>=20
> But if we didn't get an interrupt in that time?
>=20
> We can clear it a bit later, after local_irq_enable() in __vcpu_run(). =

quoted text
> However we need a nop instruction first because "sti" keeps interrupts
> disabled for one more instruction.

IMHO, I think it is better to let kvm_guest_exit() empty (you can remove =
it, if
you want):

1st case:
- unset PF_VCPU in kvm_guest_exit(), all the tick is always for system ti=
me.
Guest time is always 0.

1st case and half:

- like 1st case but we move kvm_guest_exit() as you propose and the reaso=
n of
the interrupt is the tick interrupt. The tick is for guest time only. I t=
hink
the probability is very low.

2nd case:
- don't unset PF_VCPU in kvm_guest_exit(), all the tick is for guest time=
=2E

I proposed a patch allowing to be more accurate, but it introduces more
complexity and system and user time accounting are not very accurate too =
(the
tick if for system if it appears whereas we are in system, for user if it=

appears whereas we are in user).

Laurent
--=20
---------------- Laurent.Vivier@bull.net  -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond