Avi Kivity wrote:
quoted text
> Ingo Molnar wrote:
>> * Avi Kivity <avi@qumranet.com> wrote:
>>
>> =20
>>> This bit can go; for the external module I can add it back in
>>> external-module-compat.h.  No need to pollute mainline with backward
>>> compatibility stuff.
>>>    =20
>>
>> hm:
>>
>> static inline void kvm_guest_enter(void)
>> {
>>         current->flags |=3D PF_VCPU;
>> }
>>
>> static inline void kvm_guest_exit(void)
>> {
>> }
>>
>> shouldnt PF_VCPU be cleared in kvm_guest_exit()?
>>  =20
>=20
> IIRC the accounting code clears it, but yes, it may not have been calle=
d
quoted text
> at all, so clearing it here is needed.
>=20

No, It must not be cleared here because we can't enter in the accounting =
code
between kvm_guest_enter(void) and kvm_guest_exit(void).

This is why the accounting code clears it.

I put a kvm_guest_exit() only for symmetry.

Laurent
--=20
---------------- Laurent.Vivier@bull.net  -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond