Home » Mailing list archives » linux-kernel » 2007 » October » 15

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christian Borntraeger <borntraeger@...>
To: Laurent Vivier <Laurent.Vivier@...>
Cc: Ingo Molnar <mingo@...>, linux-kernel <linux-kernel@...>
Subject: Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting
Date: Monday, October 15, 2007 - 6:51 am

Am Montag, 10. September 2007 schrieb Laurent Vivier:

I would move this line
       if (p->flags & PF_VCPU) {
               account_guest_time(p, cputime);
------>                p->flags &= ~PF_VCPU;  <---------
               return;
       }
into kvm_guest_exit. Otherwise a guest that is running very long in 
guest context would only get the first tick accounted as guest time, no?

Besides that, this looks good and should work for kvm on s390 as well. 
Thanks Laurent.

Christian


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Laurent Vivier, (Mon Sep 10, 10:12 am)
Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Christian Borntraeger, (Mon Oct 15, 6:51 am)
Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Ingo Molnar, (Mon Sep 10, 3:41 pm)
Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Rik van Riel, (Tue Sep 11, 10:05 am)
Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Laurent Vivier, (Tue Sep 11, 5:38 am)
Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Rik van Riel, (Tue Sep 11, 2:59 pm)
Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting, Rik van Riel, (Mon Sep 10, 3:37 pm)