Re: [rfc][patch 3/3] x86: optimise barriers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Nick Piggin
Date: Monday, October 15, 2007 - 1:09 am

On Mon, Oct 15, 2007 at 09:44:05AM +0200, Jarek Poplawski wrote:

I'd say that's exactly what Intel wanted. It's pretty common (we do
it all the time in the kernel too) to create an API which places a
stronger requirement on the caller than is actually required. It can
make changes much less painful.

Has performance really been much problem for you? (even before the
lfence instruction, when you theoretically had to use a locked op)?
I mean, I'd struggle to find a place in the Linux kernel where there
is actually a measurable difference anywhere... and we're pretty
performance critical and I think we have a reasonable amount of lockless
code (I guess we may not have a lot of tight computational loops, though).
I'd be interested to know what, if any, application had found these
barriers to be problematic...

 

The thing is that those documents are not defining what a particular
implementation does, but how the architecture is defined (ie. what
must some arbitrary software/hardware provide and what may it expect).

It's pretty natural that Intel started out with a weaker guarantee
than their CPUs of the time actually supported, and tightened it up
after (presumably) deciding not to implement such relaxed semantics
for the forseeable future.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[rfc][patch 1/3] x86_64: fence nontemproal stores, Nick Piggin, (Wed Oct 3, 10:21 pm)
[rfc][patch 2/3] x86: fix IO write barriers, Nick Piggin, (Wed Oct 3, 10:22 pm)
[rfc][patch 3/3] x86: optimise barriers, Nick Piggin, (Wed Oct 3, 10:23 pm)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Dave Jones, (Thu Oct 4, 10:32 am)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Andi Kleen, (Thu Oct 4, 10:53 am)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Dave Jones, (Thu Oct 4, 11:10 am)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Andi Kleen, (Thu Oct 4, 11:21 am)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Dave Jones, (Thu Oct 4, 11:41 am)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Andi Kleen, (Thu Oct 4, 11:58 am)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Dave Jones, (Thu Oct 4, 12:08 pm)
Re: [rfc][patch 2/3] x86: fix IO write barriers, Alan Cox, (Thu Oct 4, 1:52 pm)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 1:25 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Helge Hafting, (Fri Oct 12, 1:42 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Nick Piggin, (Fri Oct 12, 1:57 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 2:12 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Nick Piggin, (Fri Oct 12, 2:44 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 2:55 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 3:04 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Nick Piggin, (Fri Oct 12, 3:42 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 4:55 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 5:10 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Helge Hafting, (Fri Oct 12, 5:44 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Fri Oct 12, 6:29 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Linus Torvalds, (Fri Oct 12, 8:13 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Mon Oct 15, 12:44 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Nick Piggin, (Mon Oct 15, 1:09 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Mon Oct 15, 2:10 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Mon Oct 15, 2:24 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Helge Hafting, (Mon Oct 15, 3:17 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Mon Oct 15, 4:53 am)
RE: [rfc][patch 3/3] x86: optimise barriers, David Schwartz, (Mon Oct 15, 7:38 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Nick Piggin, (Mon Oct 15, 5:50 pm)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Tue Oct 16, 2:00 am)
Re: [rfc][patch 3/3] x86: optimise barriers, david, (Tue Oct 16, 2:14 am)
Re: [rfc][patch 3/3] x86: optimise barriers, Jarek Poplawski, (Tue Oct 16, 5:49 am)